Skip to content

master: sessions support broke --enable-heterogeneous builds #9972

Closed
@jsquyres

Description

@jsquyres

It looks like #9097 (6bd36a7) introduced a compile error when using --enable-heterogeneous. Both coll/adapt and pml/ob1 get compile errors. They both appear to stem from ob1/pml_ob1_hdr.h, so I'll only list a token set of compile errors from pml/ob1 here:

  CC       pml_ob1.lo
In file included from pml_ob1.h:42,
                 from pml_ob1.c:55:
pml_ob1_hdr.h: In function ‘ob1_hdr_ntoh’:
pml_ob1_hdr.h:532:6: error: implicit declaration of function ‘MCA_PML_OB1_EXT_MATCH_HDR_NTOH’; did you mean ‘MCA_PML_OB1_MATCH_HDR_NTOH’? [-Werror=implicit-function-declaration]
      MCA_PML_OB1_EXT_MATCH_HDR_NTOH(hdr->hdr_cid);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      MCA_PML_OB1_MATCH_HDR_NTOH
pml_ob1_hdr.h:534:30: error: ‘hext_hdr’ undeclared (first use in this function); did you mean ‘next_hdr’?
      ob1_hdr_ntoh (next_hdr, hext_hdr->hdr_common.hdr_type);
                              ^~~~~~~~
                              next_hdr
pml_ob1_hdr.h:534:30: note: each undeclared identifier is reported only once for each function it appears in
pml_ob1_hdr.h: In function ‘ob1_hdr_hton_intr’:
pml_ob1_hdr.h:587:6: error: implicit declaration of function ‘MCA_PML_OB1_EXT_MATCH_HDR_HTON’; did you mean ‘MCA_PML_OB1_MATCH_HDR_HTON’? [-Werror=implicit-function-declaration]
      MCA_PML_OB1_EXT_MATCH_HDR_HTON(hdr->hdr_cid);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      MCA_PML_OB1_MATCH_HDR_HTON
pml_ob1_hdr.h:589:30: error: ‘hext_hdr’ undeclared (first use in this function); did you mean ‘next_hdr’?
      ob1_hdr_hton (next_hdr, hext_hdr->hdr_common.hdr_type, proc);
                              ^~~~~~~~
pml_ob1_hdr.h:548:46: note: in definition of macro ‘ob1_hdr_hton’
     ob1_hdr_hton_intr((mca_pml_ob1_hdr_t*)h, t, p)
                                              ^
pml_ob1.c: In function ‘mca_pml_ob1_send_cid’:
pml_ob1.c:792:50: error: invalid type argument of ‘->’ (have ‘mca_pml_ob1_cid_hdr_t’ {aka ‘struct mca_pml_ob1_cid_hdr_t’})
     ob1_hdr_hton ((mca_pml_ob1_hdr_t *) &cid, cid->hdr_common.hdr_type, proc);
                                                  ^~
pml_ob1_hdr.h:548:46: note: in definition of macro ‘ob1_hdr_hton’
     ob1_hdr_hton_intr((mca_pml_ob1_hdr_t*)h, t, p)
                                              ^
cc1: some warnings being treated as errors
make: *** [pml_ob1.lo] Error 1

This obviously needs to be fixed before sessions can be brought to the v5.0.x branch.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions