v4.1.x: README: make the heterogeneous support more clear #9970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
approved these changes
Feb 4, 2022
jsquyres
force-pushed
the
pr/v4.1.x/update-readme-heterogeneous-support
branch
from
b52994b to
9b9beee
Compare
Remove ambiguous warning language (it's not clear if the "THIS FUNCTIONALITY..." warning applies to the option above or below the warning) and make it clear exactly what the heterogeneous option supports and does not support. This is a port of 6674ba8 from master; it's not a direct cherry pick because master has README.md and the v4.1.x branch has README. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/v4.1.x/update-readme-heterogeneous-support
branch
from
9b9beee to
c89ef03
Compare
jsquyres
changed the title
|
Had to re-push without the duplicated commit from #9810 so that github didn't think there was a conflict. I also edited the commit message to say README, not README.md. The README change content is exactly the same / what was reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is intended to be merged after #9810, just to keep the history a bit simple (because #9809 -- the v4.0.x version of #9810 -- was already merged; it'll be a little easier for someone digging through git history if the same things happened on both v4.0.x and v4.1.x). This PR includes the commit from #9810 because otherwise there would be a conflict. That commit will effectively disappear from this PR once #9810 is merged. Opening this PR in a "draft" state to ensure that #9810 is merged first.
Remove ambiguous warning language (it's not clear if the "THIS
FUNCTIONALITY..." warning applies to the option above or below the
warning) and make it clear exactly what the heterogeneous option
supports and does not support.
This is a port of 6674ba8 from master; it's not a direct
cherry pick because master has README.md and the v4.1.x branch has
README.
Signed-off-by: Jeff Squyres [email protected]
bot:notacherrypick