v5.0.x: Remove smartmatch warnings from autogen.pl #9709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smartmatch was retroactively deprecated due to corner cases, so replace with a list search function that does basically the same thing (for our use case). We could theoretically use List::Util::any here, but some distros do not ship List::Util by default (Amazon Linux 2). Signed-off-by: Brian Barrett <[email protected]> (cherry picked from commit 9553e3f)
Add the hwloc version to the output of autogen.pl, to match the behavior of autogen.pl for libevent. Signed-off-by: Brian Barrett <[email protected]> (cherry picked from commit 5e79c38)
bwbarrett
approved these changes
Nov 29, 2021
Member
bwbarrett
left a comment
bwbarrett
left a comment
There was a problem hiding this comment.
Shockingly, I think it's fine. But I'm not sure my review should really count here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v5.0.x version of #9687