Remove smartmatch warnings from autogen.pl #9687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sad panda: |
Member
Author
|
It looks like the Internet lied; older versions of Perl don't include List::Util in core. I think it's time to just write this loop by hand (sigh). |
Smartmatch was retroactively deprecated due to corner cases, so replace with a list search function that does basically the same thing (for our use case). We could theoretically use List::Util::any here, but some distros do not ship List::Util by default (Amazon Linux 2). Signed-off-by: Brian Barrett <[email protected]>
Add the hwloc version to the output of autogen.pl, to match the behavior of autogen.pl for libevent. Signed-off-by: Brian Barrett <[email protected]>
bwbarrett
force-pushed
the
bugfix/smartmatch
branch
from
34ba239 to
5e79c38
Compare
jsquyres
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while editing autogen.pl, also add some minor debugging information