test: use mntent in util/opal_path_nfs #4177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs open-mpi#4167 Signed-off-by: Gilles Gouaillardet <[email protected]>
ggouaillardet
force-pushed
the
topic/test_nfs
branch
from
3077931 to
aff49e2
Compare
bwbarrett
requested changes
Sep 6, 2017
There was a problem hiding this comment.
Two things about this patch. First, it doesn't actually fix the problem (see #4176) for the base indexing problem and how it should be fixed. Second, I'm not sure it's actually the right thing to test. We're now testing that the data returned from the unit test version of opal_path_nfs() and the library version of opal_path_nfs() return the same data, because they gather data essentially the same way. The "nice" thing about the mount method is that it's two totally different ways of collecting the data. The source of the data wasn't the problem; it was just a simple array bounds problem.
|
thanks for correction, i will close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4167
Signed-off-by: Gilles Gouaillardet [email protected]