test: add bounds check for nfs test

[bwbarrett]

The nfs test builds a list of entries for all mount points on the
system, and then checks each mount point for expected results
against the opal_path_nfs() call. This test assumed that there
were less than 256 mount points on the system, which apparently
isn't true on some Cray systems. This patch makes two changes:
add the proper bound check to avoid a segmentation fault and
double the list of mount points we'll return.

Signed-off-by: Brian Barrett [email protected]

[ggouaillardet]

i incidentally noticed dirs_tmp is not correctly allocated, it should be

dirs_tmp = (char**) calloc (MAX_DIR, sizeof(char*));

(instead of sizeof(char **))

should we realloc() instead of using a larger MAX_DIR ?
so we do not get bitten again by systems with more than 512 mount points

[jsquyres]

This PR is a minimum-distance fix -- it solves the problem (even if there are more than [gulp] 512 mount points). Just for the helluvit, I filed #4179 to go slightly beyond this PR -- it counts how many mount points there are before reading them in. Hence, we'll always check all mount points (even if there are more than 512).

I don't really care which one of these 2 PRs are merged -- the "count" solution was on my brain, so I filed #4179. But both this PR and #4179 adequately solve the problem.

[jsquyres]

#4179 was taken over this one. Closing.