Skip to content

atomics/powerpc: Fix WMB instruction #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Jun 7, 2017

@jjhursey jjhursey added the bug label Jun 7, 2017
@jjhursey jjhursey added this to the v2.0.4 milestone Jun 7, 2017
@jjhursey jjhursey requested a review from hjelmn June 7, 2017 18:24
@hppritcha
Copy link
Member

bot:lanl:retest

@jsquyres
Copy link
Member

jsquyres commented Jun 8, 2017

Need to make sure all of #3668, #3669, and #3670 get merged (v2.0.x, v2.1.x, and v3.0.x versions of this PR).

@hppritcha
Copy link
Member

@jjhursey once #3675 is merged could you rebase to pick up that fix so we can jenkins to pass?

 * `lwsync` is a write memory barrier.
    - `eieio` is really not meant for this type of operation.
 * `lwsync` can also be used for the read memory barrier according to
   my reading of the of the Power 8 ISA docs (v2.07)
    - https://www-01.ibm.com/marketing/iwm/iwm/web/reg/download.do?source=swg-opower&S_PKG=dl&lang=en_US&cp=UTF-8
 * References openpmix/openpmix#391

Signed-off-by: Joshua Hursey <[email protected]>
(cherry picked from commit 4796193)
Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey jjhursey force-pushed the fix/v2.0.x/ppc-wmb branch from 24070c2 to 934219f Compare June 13, 2017 11:58
@jjhursey
Copy link
Member Author

rebased and pushed

@hppritcha hppritcha merged commit 133f04d into open-mpi:v2.0.x Jun 13, 2017
@jjhursey jjhursey deleted the fix/v2.0.x/ppc-wmb branch June 13, 2017 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants