-
Notifications
You must be signed in to change notification settings - Fork 908
v2.0.x: fortran/base: rename strings.h into fortran_base_strings.h #3675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.x: fortran/base: rename strings.h into fortran_base_strings.h #3675
Conversation
rename ompi/mpi/fortran/base/strings.h so it does not get pulled when /usr/include/strings.h is expected. Refs open-mpi#3639 Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit open-mpi/ompi@08526e8)
@bwbarrett i checked (only) the free bsd platform. |
yeah, there's a check in the script for version to avoid that bug; not sure what's happening. Unfortunately, I won't be able to look at it in the next week due to meetings and vacation. |
@bwbarrett Looks like the PRB failed because it's trying to use |
bot:lanl:retest |
@jsquyres yeah, I got that part. I found the bug; a bad regex for the versions that do / do not support --get-stack-traces. We matched the 1.x series, but not the 2.0.x series properly. Fixed now (I think), although Howard's current build is going to fail same as the first one... |
are we ready to have jenkins get another go at this one? |
Yeah, I pushed what I think is the fix on Thursday. bot:ompi:retest |
hmm.. looks like we're still picking up the |
bot:ompi:retest |
(open-mpi/ompi-scripts#2 should have fixed the |
Try again, with open-mpi/ompi-scripts#3... bot:ompi:retest |
rename ompi/mpi/fortran/base/strings.h so it does not get pulled
when /usr/include/strings.h is expected.
Refs #3639
Signed-off-by: Gilles Gouaillardet [email protected]
(cherry picked from commit 08526e8)