pcomm:fix fortran interface for precv/psend #11986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
reviewed
Oct 12, 2023
| @@ -310,9 +310,11 @@ end subroutine ompi_issend_f | |||
|
|
|||
| subroutine ompi_psend_init_f(buf,partitions,count,datatype,dest,tag,comm,info,request,ierror) & | |||
| BIND(C, name="ompi_psend_init_f") | |||
| use :: mpi_f08_types, only : MPI_Status, MPI_COUNT_KIND | |||
| @@ -322,9 +324,11 @@ end subroutine ompi_psend_init_f | |||
|
|
|||
| subroutine ompi_precv_init_f(buf,partitions,count,datatype,dest,tag,comm,info,request,ierror) & | |||
| BIND(C, name="ompi_precv_init_f") | |||
| use :: mpi_f08_types, only : MPI_Status, MPI_COUNT_KIND | |||
| @@ -7,16 +7,19 @@ | |||
| ! and Technology (RIST). All rights reserved. | |||
| ! Copyright (c) 2020 Sandia National Laboratories. All rights reserved. | |||
| ! Copyright (c) 2021 Bull S.A.S. All rights reserved. | |||
| ! Copyright (c) 2022 Triad National Security, LLC. All rights | |||
|
Looks good to me other than the small items Jeff already pointed out. |
The Fortran interfaces were using INTEGER for count argument. The MPI-4 standard states that this argument should be INTEGER(KIND=MPI_COUNT_KIND). related to open-mpi#11982 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
fix_fort_psendrecv
branch
from
fb58657 to
e1134af
Compare
lrbison
approved these changes
Oct 12, 2023
jsquyres
approved these changes
Oct 13, 2023
|
@hppritcha Thank you! Do you plan to backport to v5.0.x? |
|
Yes later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fortran interfaces were using INTEGER for count argument. The MPI-4 standard states that this argument should be INTEGER(KIND=MPI_COUNT_KIND).
related to #11982