Skip to content

main/v5.0: bad Fortran bindings for MPI_PSEND|RECV_INIT #11982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsquyres opened this issue Oct 11, 2023 · 3 comments
Closed

main/v5.0: bad Fortran bindings for MPI_PSEND|RECV_INIT #11982

jsquyres opened this issue Oct 11, 2023 · 3 comments
Assignees
@hppritcha
Labels
bug Target: main Target: v5.0.x
Milestone
v5.0.0

Comments

@jsquyres
Copy link
Member

Per #11967 (comment), regarding the MPI_PSEND_INIT / MPI_PRECV_INIT routines:

  • The mpi_f08 binding has the count argument as type INTEGER
    • According to MPI-4.0, this should be INTEGER(KIND=MPI_COUNT_KIND)
  • The other Fortran bindings has the count argument as type INTEGER
    • According to MPI-4.0, this should be INTEGER(KIND=MPI_COUNT_KIND)
@jsquyres jsquyres added this to the v5.0.0 milestone Oct 11, 2023
@jsquyres jsquyres mentioned this issue Oct 11, 2023
Closed
hppritcha added a commit to hppritcha/ompi that referenced this issue Oct 12, 2023
@hppritcha
pcomm:fix fortran interface for precv/psend
e161bd3 
The Fortran interfaces were using INTEGER for count
arguement.  The MPI-4 standard states that this argument
should be INTEGER(KIND=MPI_COUNT_KIND).

related to open-mpi#11982

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Oct 12, 2023
@hppritcha
pcomm:fix fortran interface for precv/psend
fb58657 
The Fortran interfaces were using INTEGER for count
argument.  The MPI-4 standard states that this argument
should be INTEGER(KIND=MPI_COUNT_KIND).

related to open-mpi#11982

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha mentioned this issue Oct 12, 2023
Merged
hppritcha added a commit to hppritcha/ompi that referenced this issue Oct 12, 2023
@hppritcha
pcomm:fix fortran interface for precv/psend
e1134af 
The Fortran interfaces were using INTEGER for count
argument.  The MPI-4 standard states that this argument
should be INTEGER(KIND=MPI_COUNT_KIND).

related to open-mpi#11982

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Oct 13, 2023
@hppritcha
pcomm:fix fortran interface for precv/psend
28101cb 
The Fortran interfaces were using INTEGER for count
argument.  The MPI-4 standard states that this argument
should be INTEGER(KIND=MPI_COUNT_KIND).

related to open-mpi#11982

Signed-off-by: Howard Pritchard <[email protected]>
(cherry picked from commit e1134af)
@hppritcha hppritcha mentioned this issue Oct 13, 2023
Merged
@lrbison
Copy link
Contributor

lrbison commented Oct 17, 2023

I think this can be closed?

@hppritcha
Copy link
Member

Yes

@jsquyres
Copy link
Member Author

All fixed. Closing.

bosilca pushed a commit to bosilca/ompi that referenced this issue Feb 14, 2024
@hppritcha @bosilca
pcomm:fix fortran interface for precv/psend
9dfb2b8 
The Fortran interfaces were using INTEGER for count
argument.  The MPI-4 standard states that this argument
should be INTEGER(KIND=MPI_COUNT_KIND).

related to open-mpi#11982

Signed-off-by: Howard Pritchard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hppritcha hppritcha

Labels
bug Target: main Target: v5.0.x
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
3 participants
@jsquyres @hppritcha @lrbison