Skip to content

Ensure v3.x commits are cherry picked to v3.0.x #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsquyres opened this issue Jul 5, 2017 · 3 comments
Closed

Ensure v3.x commits are cherry picked to v3.0.x #3810

jsquyres opened this issue Jul 5, 2017 · 3 comments
Assignees
@hppritcha @bwbarrett
Labels
bug code cleanup
Milestone
v3.0.0

Comments

@jsquyres
Copy link
Member

jsquyres commented Jul 5, 2017

Per #3806 (comment), it looks like there were at least a few PRs that were merged to the v3.x branch even after it was defunct (first email I see about creating a nightly v3.0.x tarball was on May 30).

Probably need to audit the logs on the v3.x branch and ensure that all PRs that were applied there got applied to the v3.0.x branch.

Assigning this to the v3.0.0 RMs simply because I don't know who else to assign it to...
@jsquyres jsquyres added this to the v3.0.0 milestone Jul 5, 2017
@jsquyres jsquyres mentioned this issue Jul 5, 2017
Merged
@hppritcha
Copy link
Member

#3677 looks suspect.
#3568 looks suspect.q

Note I don't have write permissions on v3.x branch now so can't merge.

@karasevb
Copy link
Member

There is #3677 was already added to v3.0.x branch as a part of PR #3723

@bwbarrett
Copy link
Member

Closing this issue; we completed the audit and haven't missed any patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hppritcha hppritcha

@bwbarrett bwbarrett

Labels
bug code cleanup
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
4 participants
@jsquyres @hppritcha @bwbarrett @karasevb