Skip to content

v3.x: mca/sensor: replace OMPI macro with ORTE macro #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ggouaillardet
Copy link
Contributor

and keep autogen.pl --no-ompi happy

This is a one-off commit for the v3.x branch

Signed-off-by: Gilles Gouaillardet [email protected]

and keep autogen.pl --no-ompi happy

This is a one-off commit for the v3.x branch

Signed-off-by: Gilles Gouaillardet <[email protected]>
@ggouaillardet ggouaillardet added this to the v3.1.0 milestone Jul 4, 2017
@ggouaillardet ggouaillardet requested a review from rhc54 July 4, 2017 02:39
@ggouaillardet
Copy link
Contributor Author

@rhc54 @bwbarrett i found this issue with autogen.pl --no-ompi
incidentally, i found the sensor framework has been restored only for the v3.x branch, and not in the master branch. is this what was intended ?

@rhc54
Copy link
Contributor

rhc54 commented Jul 4, 2017

It should have been removed as part of the PR I submitted and Brian committed. I wonder if git somehow failed to remove it? Check the tarball and see if it is there. If so, then the entire framework should be removed.

@ggouaillardet
Copy link
Contributor Author

the framework was removed back in April 2014, but you restored it in March 2017
https://github.com/open-mpi/ompi/commits/v3.x/orte/mca/sensor
anyway, if it should be removed, then please close this PR and i will make a new one

@rhc54
Copy link
Contributor

rhc54 commented Jul 4, 2017

I just looked again, and there is no sensor framework in v3.0.x. I believe the problem here is that you are looking at the stale branch (v3.x). We switched to v3.0.x a couple of months ago.

@rhc54 rhc54 closed this Jul 4, 2017
@ggouaillardet
Copy link
Contributor Author

yes, i did look in the v3.x branch. a PR was merged 20 hours ago, so from my point of view, it is not really a stale branch. btw, if it is a stale branch, why not simply remove it ?
@bwbarrett any thoughts ?

@rhc54
Copy link
Contributor

rhc54 commented Jul 4, 2017

I'll bet that Brian didn't realize the PR was against the old branch and merged it. FWIW: I believe it was removed, but if you merge a PR it gets recreated. We'll have to remove it again and that PR has to be resubmitted.

@jsquyres
Copy link
Member

jsquyres commented Jul 5, 2017

Yes, we really should remove the v3.x branch to avoid confusion like this.

Oy... looking at the logs in v3.x, it looks like there have been several merges over in the past month. 😦

The first nightly build email I see for the v3.0.x branch was on May 30. It looks like I updated Cisco's MTT to point to the v3.0.x download area on May 31.

@bwbarrett
Copy link
Member

@ggouaillardet, v3.x is dead. Someone made a mistake in submitting PRs to it, Github for reasons no one understands allowed me to merge into 3.x (despite permissions that should disallow any merging from anyone), etc. We'll kill off the branch this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants