-
Notifications
You must be signed in to change notification settings - Fork 900
v3.x: mca/sensor: replace OMPI macro with ORTE macro #3806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.x: mca/sensor: replace OMPI macro with ORTE macro #3806
Conversation
and keep autogen.pl --no-ompi happy This is a one-off commit for the v3.x branch Signed-off-by: Gilles Gouaillardet <[email protected]>
@rhc54 @bwbarrett i found this issue with |
It should have been removed as part of the PR I submitted and Brian committed. I wonder if git somehow failed to remove it? Check the tarball and see if it is there. If so, then the entire framework should be removed. |
the framework was removed back in April 2014, but you restored it in March 2017 |
I just looked again, and there is no sensor framework in v3.0.x. I believe the problem here is that you are looking at the stale branch (v3.x). We switched to v3.0.x a couple of months ago. |
yes, i did look in the |
I'll bet that Brian didn't realize the PR was against the old branch and merged it. FWIW: I believe it was removed, but if you merge a PR it gets recreated. We'll have to remove it again and that PR has to be resubmitted. |
Yes, we really should remove the Oy... looking at the logs in v3.x, it looks like there have been several merges over in the past month. 😦 The first nightly build email I see for the v3.0.x branch was on May 30. It looks like I updated Cisco's MTT to point to the v3.0.x download area on May 31. |
@ggouaillardet, v3.x is dead. Someone made a mistake in submitting PRs to it, Github for reasons no one understands allowed me to merge into 3.x (despite permissions that should disallow any merging from anyone), etc. We'll kill off the branch this week. |
and keep autogen.pl --no-ompi happy
This is a one-off commit for the v3.x branch
Signed-off-by: Gilles Gouaillardet [email protected]