Skip to content

Conversation

@federicobond
Copy link
Member

@federicobond federicobond commented Feb 9, 2024

Remove @abstractmethod decorator which is causing build failures in open-feature/python-sdk-contrib#37 (comment)

The method already provides a default implementation.

@codecov
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9833ba) 94.41% compared to head (b413401) 94.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   94.41%   94.40%   -0.02%     
==========================================
  Files          17       17              
  Lines         448      447       -1     
==========================================
- Hits          423      422       -1     
  Misses         25       25              
Flag Coverage Δ
unittests 94.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@federicobond federicobond force-pushed the remove-abstractmethod branch from 05e24e7 to b413401 Compare February 9, 2024 21:09
@federicobond federicobond merged commit 77fbae7 into open-feature:main Feb 9, 2024
@federicobond federicobond deleted the remove-abstractmethod branch February 14, 2024 22:45
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
…spec digest to a367871 (open-feature#274)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants