-
Notifications
You must be signed in to change notification settings - Fork 23
chore: update ruff version to 0.2.1 and remove preview flag #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 90.55% 89.92% -0.64%
==========================================
Files 8 6 -2
Lines 180 129 -51
==========================================
- Hits 163 116 -47
+ Misses 17 13 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matthewelwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@federicobond the change here looks sound to me but I'm confused by the workflows failure. I can't seen anything in this PR that would cause this but it seems that the same workflow passed on the last run on the main branch and your last PR branch. Any ideas?
|
@matthewelwell is is probably a side-effect of the recently released version 0.4.2 with this change open-feature/python-sdk#268. The either we add this method to the |
|
Yeah, weird that it worked before. I'm in favor of removing the |
07c6b74 to
d8fda46
Compare
|
This is now building correctly. |
d8fda46 to
1559986
Compare
Signed-off-by: Federico Bond <[email protected]>
1559986 to
4abf187
Compare
|
@gruebel perhaps we can trigger a release after merging this PR? |
Matches open-feature/python-sdk#272