Skip to content

Conversation

nibon7
Copy link
Contributor

@nibon7 nibon7 commented Oct 26, 2022

No description provided.

@fdncred fdncred merged commit 9e4ffa7 into nushell:main Oct 26, 2022
@fdncred
Copy link
Contributor

fdncred commented Oct 26, 2022

thanks

@nibon7 nibon7 deleted the right_prompt_guide branch October 27, 2022 00:06
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
)

This PR fixes the conflicts between git-completions.nu and
git-aliases.nu.

Prior to this PR you would see problems like this
```nushell
❯ use custom-completions\git\git-completions.nu *
❯ use aliases\git\git-aliases.nu
Error: nu::parser::missing_flag_param

  × Missing flag argument.
    ╭─[D:\nu_scripts\aliases\git\git-aliases.nu:64:1]
 64 │ export alias gco = git checkout
 65 │ export alias gcor = git checkout --recurse-submodules
    ·                                  ──────────┬─────────
    ·                                            ╰── flag missing string argument
 66 │ export alias gcount = git shortlog --summary --numbered
    ╰────
```
This is because, in this example, in git-completions.nu, there is a
custom command named `git checkout` that takes a `--recurse-submodules:
string` parameter, which means it's expecting a string. Removing the `:
string` part fixes the issue and allows the files to be sourced/used as
expected.

This seems more like a hack than a fix. I'm not sure if this behavior is
intended or not, but this PR fixes it anyway.

close nushell#493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants