remove dfr from dataframe chapter #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayax79
pushed a commit
to ayax79/nushell.github.io
that referenced
this pull request
Jun 26, 2024
) This PR fixes the conflicts between git-completions.nu and git-aliases.nu. Prior to this PR you would see problems like this ```nushell ❯ use custom-completions\git\git-completions.nu * ❯ use aliases\git\git-aliases.nu Error: nu::parser::missing_flag_param × Missing flag argument. ╭─[D:\nu_scripts\aliases\git\git-aliases.nu:64:1] 64 │ export alias gco = git checkout 65 │ export alias gcor = git checkout --recurse-submodules · ──────────┬───────── · ╰── flag missing string argument 66 │ export alias gcount = git shortlog --summary --numbered ╰──── ``` This is because, in this example, in git-completions.nu, there is a custom command named `git checkout` that takes a `--recurse-submodules: string` parameter, which means it's expecting a string. Removing the `: string` part fixes the issue and allows the files to be sourced/used as expected. This seems more like a hack than a fix. I'm not sure if this behavior is intended or not, but this PR fixes it anyway. close nushell#493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.