Skip to content

Update the use of inline shortcodes (figure, image, button) #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Apr 28, 2025

Hello team!

As part of figure, image and button shortcodes as being updated on this PR I created this PR to prepare the website for moving to the new syntax when a new version is released!


Pinging @agriyakhetarpal

Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for numpy-org failed.

Name Link
🔨 Latest commit c33f76e
🔍 Latest deploy log https://app.netlify.com/projects/numpy-org/deploys/6838695147655300082ce8e1

@goanpeca
Copy link
Collaborator Author

The PR on the Hugo theme is ready!
scientific-python/scientific-python-hugo-theme#674

Thanks @agriyakhetarpal

@goanpeca goanpeca changed the title Test change of figure shortcode Update the use of inline shortcodes (figure, image, button) May 20, 2025
@goanpeca goanpeca force-pushed the fix/markup branch 4 times, most recently from 9aef89b to 0a6f01a Compare May 23, 2025 12:11
@goanpeca goanpeca force-pushed the fix/markup branch 2 times, most recently from 5b025c8 to 064db41 Compare May 28, 2025 23:23
@goanpeca
Copy link
Collaborator Author

Hi @agriyakhetarpal, I have tested this PR against your PR branch. All works now :)

Copy link
Contributor

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @goanpeca! Looks good to me with one small comment about a broken link.

@goanpeca
Copy link
Collaborator Author

@agriyakhetarpal fixed the issue. Thanks!

@goanpeca goanpeca requested a review from agriyakhetarpal May 29, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants