Skip to content

fix: correctProtocol misparsing protocol #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

fix: correctProtocol misparsing protocol #314

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b273bb
fix: correctProtocol misparsing protocol
markovejnovic Oct 7, 2025
65e21d0
chore: Add some comments to correctProtocol
markovejnovic Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/parse-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ const correctProtocol = (arg, protocols) => {
return arg
}

const doubleSlash = arg.indexOf('//')
if (doubleSlash === firstColon + 1) {
return arg
}

const firstAt = arg.indexOf('@')
if (firstAt > -1) {
if (firstAt > firstColon) {
Expand All @@ -30,11 +35,6 @@ const correctProtocol = (arg, protocols) => {
}
}

const doubleSlash = arg.indexOf('//')
if (doubleSlash === firstColon + 1) {
return arg
}

return `${arg.slice(0, firstColon + 1)}//${arg.slice(firstColon + 1)}`
}

Expand Down
7 changes: 7 additions & 0 deletions test/parse-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,10 @@ t.test('can parse file urls', async t => {
t.ok(parseUrl(u))
t.ok(HostedGit.parseUrl(u))
})

t.test('can parse custom urls', async t => {
const u = 'foobar://user:host@path'
t.ok(parseUrl(u, {}))
t.equal(parseUrl(u, {}).protocol, 'foobar:')
t.ok(HostedGit.parseUrl(u))
})