fix: correctProtocol misparsing protocol

[markovejnovic]

Fixes #213.

Tests pass locally:

[markovejnovic]

I've also added a new test which fails on mainline but succeeds with this patch. I don't really know if this is a desirable fix, but my proposed implementation feels more correct than what we have in mainline.

[wraithgar]

Since the whole purpose of the function is to add the // to shorthand urls, this change makes sense: giving precedence to things that already have the // first.

However I fail to see what it has to do with #213.

[markovejnovic]

Hi @wraithgar, thanks for the prompt response.

Sorry, I accidentally opened the ticket on the npm-package-arg repo: npm/npm-package-arg#213

Here's the relevant ticket: #315

[markovejnovic]

@wraithgar, I've also added some comments to help clear up what each of the branches is responsible for. I can revert that change if you prefer, feel free to let me know

[markovejnovic]

I'm not 100% sure my understanding behind the intent here is correct

[wraithgar]

This is for shorthand like: [email protected]:npm/hosted-git-info.git

[wraithgar]

I've also added some comments to help clear up what each of the branches is responsible for. I can revert that change if you prefer, feel free to let me know

Comments are fine! Please don't length wrap them though, it's less accessible. Rule of thumb is markdown, comments, and strings for output shouldn't wrap. It's much easier to handle with a screen reader that way.

[markovejnovic]

I've also added some comments to help clear up what each of the branches is responsible for. I can revert that change if you prefer, feel free to let me know

Comments are fine! Please don't length wrap them though, it's less accessible. Rule of thumb is markdown, comments, and strings for output shouldn't wrap. It's much easier to handle with a screen reader that way.

TIL, thanks! Also comments were too verbose so I slimmed them down.