Skip to content

doc: add security release to banner #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2022
Merged

doc: add security release to banner #4490

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b44941
Update site.json
joesepi Mar 14, 2022
da29534
Update locale/en/site.json
mhdawson Mar 14, 2022
f489eb6
Update locale/en/site.json
mhdawson Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions locale/en/site.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,15 +163,10 @@
},
"banners": {
"index": {
"startDate": "2022-01-04T16:00:00.000Z",
"endDate": "2022-01-25T16:00:00.000Z",
"text": "New security releases now available for Node.js 12, 14, 16, and 17 release lines",
"link": "https://nodejs.org/en/blog/vulnerability/jan-2022-security-releases/"
},
"blacklivesmatter": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the index banner, not this one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes that banner info from site.json, which I think is OK, but if you want/need it in a separate PR, I guess we could do that too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nschonni just pushed a change to limit to the right part, look ok?

"visible": false,
"text": "#BlackLivesMatter",
"link": "black-lives-matter/"
"startDate": "2022-03-14T12:00:00.000Z",
"endDate": "2022-03-28T12:00:00.000Z",
"text": "OpenSSL security releases may require Node.js security releases",
"link": "https://nodejs.org/en/blog/vulnerability/openssl-and-high-severity-fixes-mar-2022/"
}
}
}