doc: add security release to banner #4490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
reviewed
Mar 14, 2022
| "text": "New security releases now available for Node.js 12, 14, 16, and 17 release lines", | ||
| "link": "https://nodejs.org/en/blog/vulnerability/jan-2022-security-releases/" | ||
| }, | ||
| "blacklivesmatter": { |
There was a problem hiding this comment.
Just update the index banner, not this one
There was a problem hiding this comment.
This removes that banner info from site.json, which I think is OK, but if you want/need it in a separate PR, I guess we could do that too.
There was a problem hiding this comment.
@nschonni just pushed a change to limit to the right part, look ok?
Trott
approved these changes
Mar 14, 2022
|
@nschonni are you ok with the change as is? would be good to get the banner live for the security release pre-annouce. |
|
It's probably OK, but there was templating logic that still exists for that variable |
mhdawson
reviewed
Mar 14, 2022
mhdawson
reviewed
Mar 14, 2022
nschonni
approved these changes
Mar 15, 2022
|
The link 404s. |
SEWeiTung
pushed a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missed this in previous PR.