Skip to content

Temp revert 44483b6 #14142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2017
Merged

Temp revert 44483b6 #14142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions test/parallel/test-process-kill-null.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,29 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
const common = require('../common');
require('../common');
const assert = require('assert');
const spawn = require('child_process').spawn;

const child = common.isWindows ? spawn('cmd.exe') : spawn('cat');
const cat = spawn('cat');
let called;

assert.ok(process.kill(child.pid, 0));
assert.ok(process.kill(cat.pid, 0));

child.on('exit', common.mustCall(function() {
cat.on('exit', function() {
assert.throws(function() {
process.kill(child.pid, 0);
process.kill(cat.pid, 0);
}, Error);
}));
});

child.stdout.on('data', common.mustCall(function() {
process.kill(child.pid, 'SIGKILL');
}));
cat.stdout.on('data', function() {
called = true;
process.kill(cat.pid, 'SIGKILL');
});

// EPIPE when null sig fails
child.stdin.write('test');
cat.stdin.write('test');

process.on('exit', function() {
assert.ok(called);
});