Skip to content

Temp revert 44483b6 #14142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2017
Merged

Temp revert 44483b6 #14142

merged 1 commit into from
Jul 9, 2017

Conversation

refack
Copy link
Contributor

@refack refack commented Jul 9, 2017

Ref: #14099
Fixes: #14141

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,process

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 9, 2017
@refack refack force-pushed the temp-revert-44483b6 branch from eb5f8ba to 1701813 Compare July 9, 2017 03:52
@refack refack mentioned this pull request Jul 9, 2017
Closed
Trott
Trott approved these changes Jul 9, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@refack
Copy link
Contributor Author

refack commented Jul 9, 2017

CI: https://ci.nodejs.org/job/node-test-commit/11031/
I want to land this later today if there are no objections.

@mscdex mscdex added process Issues and PRs related to the process subsystem. windows Issues and PRs related to the Windows platform. labels Jul 9, 2017
@refack refack force-pushed the temp-revert-44483b6 branch from 1701813 to 7c19247 Compare July 9, 2017 17:06
@refack
Revert "test: improve test-process-kill-null for Windows"
d69ecc6 
This reverts commit 44483b6.

PR-URL: nodejs#14142
Fixes: nodejs#14141
Refs: nodejs#14099
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@refack refack force-pushed the temp-revert-44483b6 branch from 7c19247 to d69ecc6 Compare July 9, 2017 17:08
@refack refack merged commit d69ecc6 into nodejs:master Jul 9, 2017
@refack
Copy link
Contributor Author

refack commented Jul 9, 2017 •
edited
Loading

1 run windows CI - https://ci.nodejs.org/job/node-test-commit-windows-fanned/10289/ ✔️
100 run stress - https://ci.nodejs.org/job/node-stress-single-test/1316/ https://ci.nodejs.org/job/node-stress-single-test/1317/

@refack refack deleted the temp-revert-44483b6 branch July 9, 2017 17:14
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: new flakiness in test-process-kill-null.js

7 participants

@refack @Trott @lpinca @cjihrig @mscdex @addaleax @nodejs-github-bot