Skip to content

fix an err in oauth midware #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaozhongliu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix an err in oauth midware #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/oauth_middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ module.exports = function oauth(options) {
return function (req, res, next) {
if (req.url.indexOf(options.callbackPath) === 0) {
oauthCallback(req, res, next, options);
} else if (req.url.indexOf(options.loginPath) === 0) {
login(req, res, next, options);
} else if (req.url.indexOf(options.logoutPath) === 0) {
logout(req, res, next, options);
} else if (req.url.indexOf(options.loginPath) === 0) {
Copy link
Member

@fengmk2 fengmk2 Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's different here?

Copy link
Author

@xiaozhongliu xiaozhongliu Jan 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengmk2 using the original code, when you visit '/oauth/logout', login() gets called.

login(req, res, next, options);
} else {
next();
}
Expand Down