fix an err in oauth midware #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when requesting /oauth/logout, the relevant if branch of "logoutPath" won't get reached. because the url will match /oauth , the if branch of "loginPath" will intercept the execution.
|
@xiaozhongliu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @hbbalfred and @iwillwen to be potential reviewers. |
Author
|
@fengmk2 not able to add a reviewer, so @ you here :) |
fengmk2
reviewed
Jan 17, 2017
| login(req, res, next, options); | ||
| } else if (req.url.indexOf(options.logoutPath) === 0) { | ||
| logout(req, res, next, options); | ||
| } else if (req.url.indexOf(options.loginPath) === 0) { |
Author
There was a problem hiding this comment.
@fengmk2 using the original code, when you visit '/oauth/logout', login() gets called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when requesting /oauth/logout, the relevant if branch of "logoutPath" won't get reached.
because the url will match /oauth , the if branch of "loginPath" will intercept the execution.