Skip to content

REL: 2.3.0 #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 12, 2018
Merged

REL: 2.3.0 #632

merged 11 commits into from
Jun 12, 2018

Conversation

effigies
Copy link
Member

@effigies effigies commented May 30, 2018

Open issues/PRs that could go in quickly

Pre-release checklist

Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist

Closes #622
Closes #631

@codecov-io
Copy link

codecov-io commented May 30, 2018

Codecov Report

Merging #632 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files          92       92           
  Lines       11278    11278           
  Branches     1848     1848           
=======================================
  Hits        10017    10017           
  Misses        926      926           
  Partials      335      335
Impacted Files Coverage Δ
nibabel/info.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0045ed4...12da3be. Read the comment docs.

@coveralls
Copy link

coveralls commented May 30, 2018

Coverage Status

Coverage remained the same at 91.789% when pulling 12da3be on rel/2.3.0 into 0045ed4 on master.

@pauldmccarthy
Copy link
Contributor

Hey @effigies and @matthew-brett , I will try and finish off #614 over the next week.

@effigies
Copy link
Member Author

@pauldmccarthy For the sake of having enough time to properly test and release before OHBM, I would like to avoid merging anything for 2.3.0 after tomorrow.

Finishing this off soon would obviously be welcome, and I would support a micro-release once it is in, as I think deprecating that API sooner than later would be a good move. Just wanted to comment, to calibrate your expectations, here.

@effigies
Copy link
Member Author

Also, part of the short turnaround here has to do with the holiday this past Monday. I was mentally in Tuesday, yesterday, so I didn't realize I was giving only 2 days warning.

@pauldmccarthy
Copy link
Contributor

@effigies Ok ... I have just moved house (relocated across the country), but will do my best to get it in a mergable state over the next couple of days!

@effigies
Copy link
Member Author

effigies commented Jun 1, 2018

@matthew-brett There seem to be issues with the nibabel-py2.7-osx-10.10 and nibabel-bdist64-27 buildbots. On the former, pip has been failing since Mar 29. On the latter, the buildslave has been down since at least Apr 13.

@matthew-brett
Copy link
Member

Sorry about the buildbots - I'm not in that office any more so it's harder to maintain them.

I fixed the OSX build. I'll ask someone to reboot the Windows machine that appears to be down.

@yarikoptic
Copy link
Member

I would really love to see #615 merged since it is the right thing to do ;-) BUT I've stumbled on difficulty to make doctests to not crash while trying to import that fuse-based dicomfs submodule which wouldn't be present on some systems... any hints would be super useful

@nibotmi
Copy link
Contributor

nibotmi commented Jun 2, 2018

☔ The latest upstream changes (presumably #550) made this pull request unmergeable. Please resolve the merge conflicts.

@effigies effigies merged commit 1ea6392 into master Jun 12, 2018
@effigies effigies deleted the rel/2.3.0 branch June 12, 2018 17:01
@yarikoptic
Copy link
Member

@effigies tested a few reverse depends on stretch (on sid - there are issues we need to fix in them) -- all good. The only one is dcmstack for which we fixed the issue in nibabel for deterministic slice order magic -- yet to upload fresh release (0.7.0) so could be ignored I think (alternatively, I could test again or fix up later)

neurodebian@smaug ..uilds/nibabel/2.3.0+git432-g58418066-1 % cat nibabel_2.3.0+git432-g58418066-1~nd90+1_amd64.testrdepends.nd+debian-stretch.summary

Testing builds against nibabel_2.3.0+git432-g58418066-1~nd90+1.dsc
cfflib_2.0.5-2.dsc                                 ok      ok
dcmstack_0.6.2+git33-gb43919a.1-1.dsc              ok   FAILED /home/neurodebian/deb/builds/nibabel/2.3.0+git432-g58418066-1/nibabel_2.3.0+git432-g58418066-1~nd90+1_amd64.testrdepends.nd+debian-stretch/srcs/new/dcmstack_0.6.2+git33-gb43919a.1-1_amd64.build
nitime_0.7-1.dsc                                   ok      ok
pymvpa2_2.6.0-1.dsc                                ok      ok
pysurfer_0.7-2.1~deb9u1.dsc                        ok      ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETA for next nibabel release? 2.3 release?
7 participants