-
Notifications
You must be signed in to change notification settings - Fork 262
REL: 2.3.0 #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL: 2.3.0 #632
Conversation
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
=======================================
Coverage 88.81% 88.81%
=======================================
Files 92 92
Lines 11278 11278
Branches 1848 1848
=======================================
Hits 10017 10017
Misses 926 926
Partials 335 335
Continue to review full report at Codecov.
|
Hey @effigies and @matthew-brett , I will try and finish off #614 over the next week. |
@pauldmccarthy For the sake of having enough time to properly test and release before OHBM, I would like to avoid merging anything for 2.3.0 after tomorrow. Finishing this off soon would obviously be welcome, and I would support a micro-release once it is in, as I think deprecating that API sooner than later would be a good move. Just wanted to comment, to calibrate your expectations, here. |
Also, part of the short turnaround here has to do with the holiday this past Monday. I was mentally in Tuesday, yesterday, so I didn't realize I was giving only 2 days warning. |
@effigies Ok ... I have just moved house (relocated across the country), but will do my best to get it in a mergable state over the next couple of days! |
@matthew-brett There seem to be issues with the nibabel-py2.7-osx-10.10 and nibabel-bdist64-27 buildbots. On the former, pip has been failing since Mar 29. On the latter, the buildslave has been down since at least Apr 13. |
Sorry about the buildbots - I'm not in that office any more so it's harder to maintain them. I fixed the OSX build. I'll ask someone to reboot the Windows machine that appears to be down. |
I would really love to see #615 merged since it is the right thing to do ;-) BUT I've stumbled on difficulty to make doctests to not crash while trying to import that fuse-based dicomfs submodule which wouldn't be present on some systems... any hints would be super useful |
☔ The latest upstream changes (presumably #550) made this pull request unmergeable. Please resolve the merge conflicts. |
@effigies tested a few reverse depends on stretch (on sid - there are issues we need to fix in them) -- all good. The only one is dcmstack for which we fixed the issue in nibabel for deterministic slice order magic -- yet to upload fresh release (0.7.0) so could be ignored I think (alternatively, I could test again or fix up later) neurodebian@smaug ..uilds/nibabel/2.3.0+git432-g58418066-1 % cat nibabel_2.3.0+git432-g58418066-1~nd90+1_amd64.testrdepends.nd+debian-stretch.summary
Testing builds against nibabel_2.3.0+git432-g58418066-1~nd90+1.dsc
cfflib_2.0.5-2.dsc ok ok
dcmstack_0.6.2+git33-gb43919a.1-1.dsc ok FAILED /home/neurodebian/deb/builds/nibabel/2.3.0+git432-g58418066-1/nibabel_2.3.0+git432-g58418066-1~nd90+1_amd64.testrdepends.nd+debian-stretch/srcs/new/dcmstack_0.6.2+git33-gb43919a.1-1_amd64.build
nitime_0.7-1.dsc ok ok
pymvpa2_2.6.0-1.dsc ok ok
pysurfer_0.7-2.1~deb9u1.dsc ok ok |
Open issues/PRs that could go in quickly
Pre-release checklist
doc/source/index.rst
and add any authors not yet acknowledged..mailmap file
if there are any duplicate authors listed fromgit shortlog -nse
.LONG_DESCRIPTION
ininfo.py
by runningmake refresh-readme
.nibabel/info.py
(e.g.NUMPY_MIN_VERSION
) and indoc/source/installation.rst
and inrequirements.txt
and.travis.yml
. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.nibabel-release-checks
make sdist-tests
errorsmake check-version-info
make check-files
make -C doc doctest
python -m compileall .
make source-release
nosetests --with-doctest nibabel
nibabel/info.py
to set_version_extra
to''
; commitAdapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist
Closes #622
Closes #631