Skip to content

ENH: adding TRK <=> TCK streamlines conversion scripts #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2018

Conversation

MarcCote
Copy link
Contributor

@MarcCote MarcCote commented Mar 7, 2018

This PR adds two small scripts to convert streamlines from one format (TRK or TCK) to the other.

We might want to wait for #601.

@codecov-io
Copy link

codecov-io commented Mar 7, 2018

Codecov Report

Merging #606 into master will decrease coverage by 0.4%.
The diff coverage is 19.35%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #606      +/-   ##
=========================================
- Coverage    90.3%   89.9%   -0.41%     
=========================================
  Files          87      89       +2     
  Lines       10813   10875      +62     
  Branches     1793    1799       +6     
=========================================
+ Hits         9765    9777      +12     
- Misses        719     769      +50     
  Partials      329     329
Impacted Files Coverage Δ
nibabel/cmdline/tck2trk.py 18.91% <18.91%> (ø)
nibabel/cmdline/trk2tck.py 20% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586c0e0...de68635. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage decreased (-0.4%) to 92.929% when pulling de68635 on MarcCote:enh_conversion_scripts into 586c0e0 on nipy:master.

@yarikoptic
Copy link
Member

FWIW #601 is merged now ;-)

@MarcCote MarcCote force-pushed the enh_conversion_scripts branch from 2a10bf7 to de68635 Compare April 13, 2018 00:53
@MarcCote
Copy link
Contributor Author

Not sure why the coverage has decreased.

@effigies effigies mentioned this pull request May 30, 2018
30 tasks
@effigies
Copy link
Member

@MarcCote Is this ready to go?

@MarcCote
Copy link
Contributor Author

MarcCote commented Jun 1, 2018

Yes, it is. There is just the coverage that slightly decreases but I don't know why. Let me know if you want me to rebase.

@effigies
Copy link
Member

effigies commented Jun 1, 2018

LGTM. Will merge this afternoon (EDT) in case anybody wants time to review.

@effigies effigies added this to the 2.3 milestone Jun 1, 2018
@effigies effigies merged commit 1584b3b into nipy:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants