RF: moving more cmdline things to the cmdline folder #615
Conversation
chrispycheng
changed the title
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 90.31% 88.84% -1.47%
==========================================
Files 87 92 +5
Lines 10816 11235 +419
Branches 1794 1839 +45
==========================================
+ Hits 9768 9982 +214
- Misses 719 921 +202
- Partials 329 332 +3
Continue to review full report at Codecov.
|
|
me still needs to figure out how to manage it to avoid freaking out crashing on |
|
@yarikoptic @chrispycheng Can you merge master, to make sure any errors are resulting from your code? |
* origin/master: (76 commits) STY: Clearer conditional FIX: Fix for NumPy deprecation Better handle pathological filenames BF: flake8 the import BF(PY3): just catch all Exceptions, patch builtins module now provided in py3k BF: be resilient to optional module non-ImportError exceptions upon import better file checks - path.exists is try/except for os.stat anyways! Using another existing exception, and shorter message removing unnecessary space that nibabel checks dont like merging with upstream master to undo changes not ready to PR/merge detecting if the input is empty early on! Apparently no one needed it ;) DOC: rewrite first line of function docstring CI: Remove duplicate Travis entry [skip ci] mv test of failure + rm redundant tests COV: Omit tests, drop obsolete omissions add: tests for `nibabel.save` TEST: Delete arrayproxies, allowing Windows to close filehandles Revert "FIX: Give Windows time to decide files are closed" bf: preserve error output if not valid klass fix: use correct CIFTI intent names ...
|
@effigies done! and fixed up one test |
|
any idea why I do not see travis report? ;-) |
|
Tests are passing. Will merge this PM, barring any outcry. |
|
I don't really know, but the pre-merge commit is passing. |
|
as for coverage -- now, that the scripts bodies are inside the |
|
I wonder why appveyor no longer runs for this PR? Is it running for the others? |
|
@effigies I am afraid that if you merge it as is, then it might cause appveyor and whatknows failures down the road. Better be safe than sorry ;-) |
|
Yeah, something's happened to AppVeyor, and it's affecting the release branch, too: https://ci.appveyor.com/project/nipy/nibabel But I don't have any permissions there, so not much I can do about it. Do you have permissions? Or do we need to bother Matthew? |
|
hm , https://help.appveyor.com/discussions/problems/11287-the-build-phase-is-set-to-msbuild-mode-default-but-no-visual-studio-project-or-solution-files-were-found#comment_44538892 suggests that we should revoke and readd somehow... but since it also happens to release branch, it is probably not me or @chrispycheng ... ? let me try on a dummy new PR to see if somehow relates to the original author of the PR |
|
I deauth and reauthed appveyor for myself and it started to run... so here itcomes! |
|
@yarikoptic I assume you saw AppVeyor is failing? Windows doesn't like |
|
@yarikoptic My change resolved the test failure. If you want to make sure that you're okay with it, you can go ahead and merge. |
|
@effigies thank you! I guess the battle field will show if we didn't miss anything ;-) |
|
Doh, either merge it or I will do when get to the laptop. Silly Travis policy to not allow merging on the phone when any tests fails |
|
Sounds good. rel/2.3.0 is synced to the latest master. We may still see #614 in, but having enough time to test is more important. If we freeze on Monday 9am EDT, would that be enough time for you to test and get a release before OHBM? |
also added .DS_Store to the .gitignore file
--help- required a fix for PY3 in nib-dicomfs (which otherwise was not tested anyhow).
It remains not tested on CI since would need
fusemodule which is not required per se