RF: moving nib-ls to a new cmdline folder

[chrispycheng]

moved nib-ls to make generic use of its functions possible for a "nib-diff" function currently in progress. Shoutout to @yarikoptic

[matthew-brett]

I hate to say this, but it would be good to have a few little tests in the new module, if only as a template for adding more later.

[chrispycheng]

@matthew-brett can I ask what tests you're looking for? nib-ls functionality?

[matthew-brett]

Sorry - I meant tests for the not-main functions that are now in the nibabel/cmdline tree.

[matthew-brett]

Tests failing here - I think you need to add nibabel.cmdline to the list of packages in setup.py. You should also add nibabel.cmdline.tests (does it have an __init__.py already. There are some extra blank lines at the top of cmdline.__init__.py. Otherwise, good to go (when tests running and passing).

[chrispycheng]

More tests to come for ap() and safe_get() functions

[coveralls]

Coverage decreased (-3.002%) to 93.358% when pulling 6d3b735 on chrispycheng:master into 96b2bda on nipy:master.

[matthew-brett]

Great, it will be good to have some more tests.

There are some PEP8 fails - see https://travis-ci.org/nipy/nibabel/jobs/351289012#L1492

[codecov-io]

Codecov Report

Merging #601 into master will decrease coverage by 4.14%.
The diff coverage is 40.68%.

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage   94.46%   90.31%   -4.15%     
==========================================
  Files         177       87      -90     
  Lines       24943    10810   -14133     
  Branches     2661     1793     -868     
==========================================
- Hits        23562     9763   -13799     
+ Misses        908      718     -190     
+ Partials      473      329     -144

Impacted Files	Coverage Δ
nibabel/cmdline/__init__.py	100% <100%> (ø)
nibabel/cmdline/ls.py	18.51% <18.51%> (ø)
nibabel/cmdline/utils.py	68.25% <68.25%> (ø)
nibabel/filename_parser.py	91.13% <0%> (ø)	⬆️
nibabel/streamlines/array_sequence.py	100% <0%> (ø)	⬆️
nibabel/tests/test_viewers.py
nibabel/cifti2/tests/test_new_cifti2.py
nibabel/tests/test_round_trip.py
nibabel/tests/test_image_load_save.py
nibabel/tests/test_imageglobals.py
... and 105 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b2bda...6d3b735. Read the comment docs.

[chrispycheng]

@matthew-brett Hi - if you have the time, could you please let me know what you think of the tests I've written? Thanks very much :-)

[yarikoptic]

Just a minor change to do and imho could be merged and improved upon later on

FTR codecov browser extension doesn't work for me ATM in neither firefox nor chromium

[yarikoptic]

please move it into test_safe_get so its purpose is clear and it doesn't get picked up by nose etc

[matthew-brett]

Yes, good idea.

[chrispycheng]

done and ready to rumble

[matthew-brett]

Yes, I agree - we can merge and improve. @chrispycheng - do you mind making the change Yarik suggested, and I will merge.