ENH: Add parser for Siemens "ASCCONV" text format #418

moloney · 2016-03-03T06:34:35Z

This format is included in most Siemens DICOM files as well as
other MR related files. It contains many important bits of meta
data.

matthew-brett · 2016-03-03T06:39:33Z

nibabel/nicom/tests/data/ascconv_sample.txt

+asCoilSelectMeas[0].aFFT_SCALE[10].lRxChannel = 11
+asCoilSelectMeas[0].aFFT_SCALE[11].flFactor = 4.69845
+asCoilSelectMeas[0].aFFT_SCALE[11].bValid = 1
+asCoilSelectMeas[0].aFFT_SCALE[11].lRxChannel = 12


Would be nice to add a test for one of these long list of lists type values.

Currently we don't parse these as lists, instead the key ends up being 'asCoilSelectMeas[0].aFFT_SCALE[6].lRxChannel'.

It would be nice to convert these to lists, but then we need to deal with some potential weirdness (like it seems some lists are using 0-based indexing and others are using 1-based indexing).

Yes, I remember now. I guess we could check whether the LHS list exists and fill with None up to the required index if not? As in:

sGroupArray.anMember[1] = 2

would create an object sGroupArray (if it doesn't exist), create a list sGroupArray.anMember with contents [None, None]... Would be a little bit of work though.

Yeah that seems reasonable and worthwhile.

I had some ideas - want me to have a go for a couple of hours, or do you already know how to solve it?

By all means, please take a crack at it! Thanks!

As you might have predicted, it took more than a couple of hours, but: moloney#3

matthew-brett · 2016-03-10T22:03:36Z

Brendan - did you get a chance to look at my PR to your branch?

TEST: Add BaseTestCase class to skip TestCases starting with ``_``

Co-Authored-By: Chris Markiewicz <[email protected]>

imagqes --> images

Typo fix

TEST: Drop nose for pytest

DOC: Attempt to find versioneer version when building docs

imagqes --> images

This format is included in most Siemens DICOM files as well as other MR related files. It contains many important bits of meta data.

codecov · 2020-03-24T23:30:05Z

Codecov Report

Merging #418 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          97       97           
  Lines       12390    12390           
  Branches     2187     2187           
=======================================
  Hits        11361    11361           
  Misses        688      688           
  Partials      341      341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae39189...ae39189. Read the comment docs.

moloney · 2020-03-24T23:47:43Z

I screwed up the merge here by doing the rebase before I merged Matthew's work, closing in favor of #896

matthew-brett reviewed Mar 3, 2016
View reviewed changes

effigies mentioned this pull request Sep 5, 2017

ENH: Add some conversions for DICOM values #419

Closed

effigies and others added 26 commits February 4, 2020 11:00

CI: Skip converted tests in nose

f2ff7fe

Merge pull request nipy#871 from effigies/test/base_test_case

4ee9e34

TEST: Add BaseTestCase class to skip TestCases starting with ``_``

TEST: pytest conversion nipy#864 nipy#865

01b1b7e

TEST: test_tractogram to pytest nipy#865 nipy#864

ade7bde

Update nibabel/streamlines/tests/test_array_sequence.py

083a89f

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_array_sequence.py

a12438c

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_array_sequence.py

a44ed46

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_array_sequence.py

68d5f98

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_array_sequence.py

312baa2

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_array_sequence.py

d2a5878

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_array_sequence.py

cffd3bf

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_array_sequence.py

b463079

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_array_sequence.py

b3fa3fb

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

6e864f5

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

cb681cd

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

8b01cd4

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

c1176ec

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

d643c7f

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

8326522

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

745108a

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

c758df7

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

d168423

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

1ad759b

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

7bc83a7

Co-Authored-By: Chris Markiewicz <[email protected]>

Update nibabel/streamlines/tests/test_tractogram.py

bfa7a3d

Co-Authored-By: Chris Markiewicz <[email protected]>

Update test_array_sequence.py

4fa17af

effigies and others added 26 commits February 19, 2020 23:30

TEST: Style and parameterization fixes for readability

7392e8f

TEST: Bad test syntax

a7f8e11

TEST/RF: Mock compress_ext_map, instead of fixture

6061651

TEST: Rename tests to ensure running

a98b023

TEST/RF: Reparametrize tests

5657d01

Typo fix

aec0837

imagqes --> images

Merge pull request nipy#893 from ZviBaratz/patch-1

23f3875

Typo fix

Merge pull request nipy#865 from nipy/pytest

d9298ed

TEST: Drop nose for pytest

CI: Fail test if docs do not build

0ecbf8d

PY3: Drop Python 2 guards, use runpy instead of exec

cc20e28

DOC: Attempt to find versioneer version when building docs

03c6c31

DOC: Skip py3k

92dc3f1

DOC: Fix "``s" pattern in changelog

b57cf1b

DOC: Address warnings and improve formatting

4ac9821

Merge pull request nipy#894 from effigies/doc/update_config

ee19d7a

DOC: Attempt to find versioneer version when building docs

Typo fix

d4598db

imagqes --> images

MNT: Update changelog, author list and Zenodo

05662b2

MNT: Drop pyproject.toml for now

b2c4209

DOC: Note pyproject.toml removal in changelog

4220f11

MNT: 3.0.3dev

ff7c276

Merge branch 'maint/3.0.x'

04ed870

NEP29+1y: Drop Python 3.5

7a62503

CI: Drop 3.5 tests, set min to 3.6, pre-release to 3.8

65d5fc6

ENH: Add parser for Siemens "ASCCONV" text format

cb8da69

This format is included in most Siemens DICOM files as well as other MR related files. It contains many important bits of meta data.

TST: Update to use pytest

216780d

Merge Matthew's work

ae39189

moloney mentioned this pull request Mar 24, 2020

ENH: Add parser for Siemens "ASCCONV" text format #896

Closed

moloney closed this Mar 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: Add parser for Siemens "ASCCONV" text format #418

ENH: Add parser for Siemens "ASCCONV" text format #418

moloney commented Mar 3, 2016

matthew-brett Mar 3, 2016

moloney Mar 3, 2016

matthew-brett Mar 4, 2016

moloney Mar 4, 2016

matthew-brett Mar 4, 2016

moloney Mar 4, 2016

matthew-brett Mar 6, 2016

matthew-brett commented Mar 10, 2016

codecov bot commented Mar 24, 2020 •

edited

Loading

moloney commented Mar 24, 2020

ENH: Add parser for Siemens "ASCCONV" text format #418

ENH: Add parser for Siemens "ASCCONV" text format #418

Conversation

moloney commented Mar 3, 2016

matthew-brett Mar 3, 2016

Choose a reason for hiding this comment

moloney Mar 3, 2016

Choose a reason for hiding this comment

matthew-brett Mar 4, 2016

Choose a reason for hiding this comment

moloney Mar 4, 2016

Choose a reason for hiding this comment

matthew-brett Mar 4, 2016

Choose a reason for hiding this comment

moloney Mar 4, 2016

Choose a reason for hiding this comment

matthew-brett Mar 6, 2016

Choose a reason for hiding this comment

matthew-brett commented Mar 10, 2016

codecov bot commented Mar 24, 2020 • edited Loading

Codecov Report

moloney commented Mar 24, 2020

codecov bot commented Mar 24, 2020 •

edited

Loading