Skip to content

TEST: Add BaseTestCase class to skip TestCases starting with _ #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 4, 2020

No description provided.

@effigies effigies requested a review from djarecka February 4, 2020 14:45
@effigies effigies mentioned this pull request Feb 4, 2020
37 tasks
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #871 into pytest will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           pytest     #871      +/-   ##
==========================================
+ Coverage   81.59%   81.62%   +0.03%     
==========================================
  Files          97       97              
  Lines       12402    12408       +6     
  Branches     2186     2187       +1     
==========================================
+ Hits        10119    10128       +9     
+ Misses       1876     1874       -2     
+ Partials      407      406       -1
Impacted Files Coverage Δ
nibabel/testing_pytest/__init__.py 78.5% <100%> (+1.27%) ⬆️
nibabel/streamlines/utils.py 100% <0%> (ø) ⬆️
nibabel/streamlines/__init__.py 100% <0%> (ø) ⬆️
nibabel/streamlines/trk.py 81.96% <0%> (ø) ⬆️
nibabel/dft.py 80.98% <0%> (ø) ⬆️
nibabel/streamlines/tck.py 80.74% <0%> (ø) ⬆️
nibabel/streamlines/tractogram.py 75.56% <0%> (ø) ⬆️
nibabel/streamlines/array_sequence.py 69.93% <0%> (ø) ⬆️
nibabel/freesurfer/io.py 94.22% <0%> (ø) ⬆️
nibabel/streamlines/tractogram_file.py 95% <0%> (ø) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f908ca4...60479c4. Read the comment docs.

@effigies
Copy link
Member Author

effigies commented Feb 4, 2020

Cancelled the tests because they're going to ❌ anyway. See https://travis-ci.com/nipy/nibabel/jobs/283443185 to verify that new failures aren't happening.

@djarecka
Copy link
Collaborator

djarecka commented Feb 4, 2020

@effigies - looks like everything is working, the only thing worries me that when you run tests like nibabel/tests/test_analyze.py, there are many SKIPPED reports, because of the _TestLabeledWrapStruct. Not sure if this was the same with nose

@effigies
Copy link
Member Author

effigies commented Feb 4, 2020

Yeah, I tried to get rid of them, but couldn't. One option is to del the class after using it, but I'm not sure it's worth it.

@djarecka
Copy link
Collaborator

djarecka commented Feb 4, 2020

yes, probably not worth it.
I believe we even had this discussion about del in DC. remember that was talking to you about my issues with this class in general

@effigies effigies merged commit 4ee9e34 into nipy:pytest Feb 4, 2020
@effigies effigies deleted the test/base_test_case branch February 4, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants