Skip to content

ENH: Add parser for Siemens "ASCCONV" text format #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 821 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
821 commits
Select commit Hold shift + click to select a range
f2ff7fe
CI: Skip converted tests in nose
effigies Feb 4, 2020
4ee9e34
Merge pull request #871 from effigies/test/base_test_case
effigies Feb 4, 2020
01b1b7e
TEST: pytest conversion #864 #865
robbisg Feb 4, 2020
ade7bde
TEST: test_tractogram to pytest #865 #864
robbisg Feb 4, 2020
083a89f
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
a12438c
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
a44ed46
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
68d5f98
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
312baa2
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
d2a5878
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
cffd3bf
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
b463079
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
b3fa3fb
Update nibabel/streamlines/tests/test_array_sequence.py
robbisg Feb 4, 2020
6e864f5
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
cb681cd
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
8b01cd4
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
c1176ec
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
d643c7f
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
8326522
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
745108a
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
c758df7
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
d168423
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
1ad759b
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
7bc83a7
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
bfa7a3d
Update nibabel/streamlines/tests/test_tractogram.py
robbisg Feb 4, 2020
4fa17af
Update test_array_sequence.py
robbisg Feb 4, 2020
51016a7
Update test_tractogram.py
robbisg Feb 4, 2020
bc0c67b
make sure cov is installed
anibalsolon Feb 4, 2020
ab2e0b8
TEST: Fix import/indentation errors
effigies Feb 4, 2020
5ec71fb
ENH: Use generic unittest.SkipTest in missing optional_package
effigies Feb 4, 2020
f2a96be
TEST: Cleanup test_array_sequence
effigies Feb 4, 2020
3b6f32a
CI: Skip more nose tests
effigies Feb 4, 2020
49909dc
TEST: Un-skip tractogram tests, style cleanups
effigies Feb 4, 2020
8fe1c2c
TEST: Fix optpkg test
effigies Feb 4, 2020
4fbcb79
TEST: Style updates to test_analyze
effigies Feb 4, 2020
24cf57d
TEST: test_trk to pytest
robbisg Feb 4, 2020
3a2b0d1
TEST: test_tck to pytest
robbisg Feb 4, 2020
d79af8b
pytest port
anibalsolon Feb 4, 2020
4d8325e
Merge pull request #872 from effigies/test/cleanups
effigies Feb 4, 2020
5695644
drop the nose
anibalsolon Feb 4, 2020
636dc55
CI: Give up trying to deselect streamlines
effigies Feb 4, 2020
85ac452
changed nosetools assert_true to assert in test_io.py
orduek Feb 4, 2020
62d53c3
finish porting gifti module tests to pytest
anibalsolon Feb 4, 2020
325080e
TEST: Style cleanup
effigies Feb 4, 2020
5f695b8
TEST: Simplify data/environment fixtures
effigies Feb 4, 2020
b985ef3
Merge remote-tracking branch 'upstream/pytest' into pytest
anibalsolon Feb 4, 2020
b66ec38
make sure cov is installed
anibalsolon Feb 4, 2020
2bc5308
changed nosetools assertion to pytest in test_mghformat.py
orduek Feb 4, 2020
f3be7b2
TEST: Simplify, reformat test_data
effigies Feb 4, 2020
92c758a
STY: Remove unused pkgutil import
effigies Feb 4, 2020
0011c11
Merge pull request #874 from robbisg/test_streamline
effigies Feb 4, 2020
1e7bdd0
test script condition
anibalsolon Feb 4, 2020
4a7a5ad
Merge branch 'pytest' into pytest
anibalsolon Feb 4, 2020
2ef9ad4
reintroduce nosetests into matrix
anibalsolon Feb 4, 2020
6817eb6
remove unnecessary dependency
anibalsolon Feb 4, 2020
9e5ef4d
Merge branch 'pytest' of github.com:anibalsolon/nibabel into pytest
anibalsolon Feb 4, 2020
2d0dc89
pytest is already tested
anibalsolon Feb 4, 2020
1725985
nose test inclusions
anibalsolon Feb 4, 2020
dba6f59
changed from numpy raises to pytest.raises and skipif
orduek Feb 4, 2020
b2676d8
windows breaklines..?
anibalsolon Feb 4, 2020
406e6dc
Changed test_mghformat.py to pytest
orduek Feb 4, 2020
ebf9471
Merge pull request #873 from anibalsolon/pytest
effigies Feb 4, 2020
fe61612
Merge pull request #875 from anibalsolon/pytest-port
effigies Feb 4, 2020
e1bb16d
small fixes
orduek Feb 4, 2020
ee4b703
Merge pull request #878 from effigies/test/cleanups2
effigies Feb 5, 2020
e763c89
TEST: Refactor NetCDF tests to be more pytest friendly
effigies Feb 5, 2020
61f6ecf
CI: Resolve Travis warnings, remove redundant job
effigies Feb 5, 2020
fb2a828
Merge pull request #879 from effigies/test/refactor_netcdf_tests
effigies Feb 5, 2020
a411f33
TEST: Use skipif mark instead of TestMinc2API.__init__
effigies Feb 5, 2020
e1da57c
TEST: Use standard syntax when possible
effigies Feb 5, 2020
dc9d82e
TEST: Use relative imports in gifti tests
effigies Feb 5, 2020
42beb1a
TEST: Simplify giftiio deprecation tests
effigies Feb 5, 2020
5d0f645
TEST: Combine imports
effigies Feb 5, 2020
979b439
TEST: Skip giftiio tests in nose
effigies Feb 5, 2020
5fdeed9
converting more tests from nibabel.tests
djarecka Feb 4, 2020
1a435fa
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
d85e79c
adding todo
djarecka Feb 4, 2020
9e6cac1
converting more tests nibabel.tests.test_s*
djarecka Feb 4, 2020
393f630
converting more tests nibabel.tests.test_t*
djarecka Feb 4, 2020
7aaa2d0
converting test_volumeutils
djarecka Feb 4, 2020
4ee8855
converting nibabel_data
djarecka Feb 4, 2020
a170497
removing todos
djarecka Feb 4, 2020
ff3cb80
Apply suggestions from code review
djarecka Feb 5, 2020
e87d3a5
Apply suggestions from code review
djarecka Feb 5, 2020
f2931ab
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
af8b386
adding todo
djarecka Feb 4, 2020
06210d5
removing todos
djarecka Feb 4, 2020
dd42dd8
small edits: suggestions from reviews
djarecka Feb 5, 2020
e55940d
ignoring tests with pytest.mark.parametrize
djarecka Feb 5, 2020
1e2caf4
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
b1fe921
adding todo
djarecka Feb 4, 2020
31c1698
converting more tests nibabel.tests.test_s*
djarecka Feb 4, 2020
e099c29
removing todos
djarecka Feb 4, 2020
264d1fa
Apply suggestions from code review
djarecka Feb 5, 2020
dd0c521
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
159956e
adding todo
djarecka Feb 4, 2020
e0da084
removing todos
djarecka Feb 4, 2020
0519f36
small edits: suggestions from reviews
djarecka Feb 5, 2020
f4f48ef
applying suggestions from 865
djarecka Feb 5, 2020
c5ccb2e
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
5122e2d
adding todo
djarecka Feb 4, 2020
a67a9c1
converting more tests nibabel.tests.test_s*
djarecka Feb 4, 2020
7013d72
removing todos
djarecka Feb 4, 2020
857bed6
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
1a24525
adding todo
djarecka Feb 4, 2020
fd2ddde
removing todos
djarecka Feb 4, 2020
920b30f
small edits: suggestions from reviews
djarecka Feb 5, 2020
f331d20
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
9751784
adding todo
djarecka Feb 4, 2020
29da7b0
converting more tests nibabel.tests.test_s*
djarecka Feb 4, 2020
f42da04
removing todos
djarecka Feb 4, 2020
dff77ba
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
61bc714
adding todo
djarecka Feb 4, 2020
338b4c3
removing todos
djarecka Feb 4, 2020
2d799c4
small edits: suggestions from reviews
djarecka Feb 5, 2020
436404f
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
831e553
adding todo
djarecka Feb 4, 2020
099e5cf
converting more tests nibabel.tests.test_s*
djarecka Feb 4, 2020
91be3bf
converting nibabel_data
djarecka Feb 4, 2020
4becc96
removing todos
djarecka Feb 4, 2020
ddb21c3
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
5ca8a74
adding todo
djarecka Feb 4, 2020
9373292
removing todos
djarecka Feb 4, 2020
20dcc69
small edits: suggestions from reviews
djarecka Feb 5, 2020
f6f5e04
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
13bacaf
adding todo
djarecka Feb 4, 2020
525b99d
converting more tests nibabel.tests.test_s*
djarecka Feb 4, 2020
82c39a1
removing todos
djarecka Feb 4, 2020
ff899a3
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
9daf10f
adding todo
djarecka Feb 4, 2020
b1d8cfb
removing todos
djarecka Feb 4, 2020
75f2ce6
small edits: suggestions from reviews
djarecka Feb 5, 2020
683a3ee
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
39c011e
adding todo
djarecka Feb 4, 2020
d5e5907
converting more tests nibabel.tests.test_s*
djarecka Feb 4, 2020
f7b49f3
removing todos
djarecka Feb 4, 2020
cdf6e18
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
8ba8134
adding todo
djarecka Feb 4, 2020
e860669
removing todos
djarecka Feb 4, 2020
32c1c17
small edits: suggestions from reviews
djarecka Feb 5, 2020
8a9f53d
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
50e7d98
adding todo
djarecka Feb 4, 2020
d4f2044
converting more tests nibabel.tests.test_s*
djarecka Feb 4, 2020
547ba92
removing todos
djarecka Feb 4, 2020
d8a15af
converting nibabel/tests/test_scripts.py
djarecka Feb 4, 2020
4e32787
adding todo
djarecka Feb 4, 2020
59af0aa
removing todos
djarecka Feb 4, 2020
a21c083
small edits: suggestions from reviews
djarecka Feb 5, 2020
8d92977
fixes to assert numpy
orduek Feb 5, 2020
ae39e06
changed nosetools assert_true to assert in test_io.py
orduek Feb 4, 2020
665b28a
changed nosetools assertion to pytest in test_mghformat.py
orduek Feb 4, 2020
441e4fe
changed from numpy raises to pytest.raises and skipif
orduek Feb 4, 2020
f99d926
Changed test_mghformat.py to pytest
orduek Feb 4, 2020
6e1e1c1
small fixes
orduek Feb 4, 2020
d27b124
fixes to assert numpy
orduek Feb 5, 2020
6890a62
Update nibabel/freesurfer/tests/test_io.py
orduek Feb 5, 2020
b7e8abb
Update nibabel/freesurfer/tests/test_io.py
orduek Feb 5, 2020
5dbe408
Update nibabel/freesurfer/tests/test_io.py
orduek Feb 5, 2020
24d96e4
Update nibabel/freesurfer/tests/test_io.py
orduek Feb 5, 2020
e8965c1
Update nibabel/freesurfer/tests/test_io.py
orduek Feb 5, 2020
bbc36d7
Update nibabel/freesurfer/tests/test_io.py
orduek Feb 5, 2020
e626a38
Update nibabel/freesurfer/tests/test_io.py
orduek Feb 5, 2020
2fb977b
Update nibabel/freesurfer/tests/test_io.py
orduek Feb 5, 2020
30a4639
added test_io to Ignore list in azure and travis
orduek Feb 5, 2020
1987f79
changes
orduek Feb 5, 2020
165da32
Update nibabel/freesurfer/tests/test_mghformat.py
orduek Feb 5, 2020
54fc107
Update nibabel/freesurfer/tests/test_mghformat.py
orduek Feb 5, 2020
27ef400
fixed style and convetion in test_io.py
orduek Feb 5, 2020
a3a2517
Merge branch 'test/pytest_freesurfer' of https://github.com/orduek/ni…
orduek Feb 5, 2020
fdd26a2
added more changes to style
orduek Feb 5, 2020
f79de1d
ignoring tests that use needs_nibabel_data
djarecka Feb 6, 2020
2539bcd
some cleaning after using nose2pytest
djarecka Feb 6, 2020
e3f171b
MNT: CI YAML formatting, extraneous .coveragerc
effigies Feb 6, 2020
eaab253
TEST: Style and formatting
effigies Feb 6, 2020
51f2485
CI: Restore import-only test
effigies Feb 6, 2020
a9bbe82
small cleaning after review
djarecka Feb 6, 2020
19b55b9
small edit
djarecka Feb 6, 2020
6838af6
Update nibabel/tests/test_image_api.py
djarecka Feb 6, 2020
6dd27a3
Merge pull request #1 from effigies/test/pytest_freesurfer
orduek Feb 6, 2020
5f4436f
Merge pull request #876 from djarecka/pytest_updates
effigies Feb 6, 2020
5064f9a
Update nibabel/freesurfer/tests/test_mghformat.py
orduek Feb 6, 2020
27f0f03
Merge branch 'pytest' into test/pytest_freesurfer
orduek Feb 6, 2020
baab901
Merge pull request #881 from orduek/test/pytest_freesurfer
effigies Feb 7, 2020
d9c385a
CI: Enable doctests
effigies Feb 7, 2020
0a49449
TEST: Use numpy 1.13 legacy print settings
effigies Feb 7, 2020
afa0f2e
Merge pull request #882 from effigies/test/doctest_modules
effigies Feb 7, 2020
40d2471
TEST: Convert nibabel.nicom to unittest/pytest
effigies Feb 7, 2020
a23c63a
TEST: Use vanilla unittest.skip* over pytest
effigies Feb 7, 2020
2542320
RF: Remove unused pieces of testing_pytest and switch to unittest skip
effigies Feb 7, 2020
a223c07
CI: Only ignore files that use fixtures
effigies Feb 8, 2020
328c236
Merge pull request #883 from effigies/test/vanilla_unittest
effigies Feb 8, 2020
78f8e71
Merge pull request #884 from effigies/test/dicom_pytest
effigies Feb 8, 2020
b2f40bd
TEST: De-indent tests, cleanup style
effigies Feb 9, 2020
8ed033c
TEST/STY: Cleaner line breaks and alignment for test_fileslice
effigies Feb 9, 2020
6be3e94
TEST/STY: Alignment in fileutils, floating tests
effigies Feb 9, 2020
84df042
TEST: cmdline module to pytest
Feb 10, 2020
103db6b
TEST: cifti2 tests to pytest
Feb 10, 2020
c7a2d77
TEST: style fixed
Feb 10, 2020
3b6896e
TEST: fixed comments
robbisg Feb 10, 2020
f8db80a
TEST/RF: Reduce redundancy in test_removalschedule, test failure case
effigies Feb 11, 2020
9183ffb
MNT/FIX: Bump minimum matplotlib to 1.5.2 to match available wheels
effigies Feb 11, 2020
50265dc
MNT: Use version 1.5.3 to smooth transition to 3.6
effigies Feb 11, 2020
bcce691
Merge pull request #887 from effigies/mnt/update_minimum_matplotlib
effigies Feb 12, 2020
d5ef496
Merge remote-tracking branch 'upstream/master' into pytest
effigies Feb 12, 2020
bb9cb15
RF: minc - delay import of h5py until needed.
yarikoptic Feb 14, 2020
29bdb59
Merge pull request #889 from yarikoptic/opt-h5py-import
effigies Feb 14, 2020
6967461
RF: minc - delay import of h5py until needed.
yarikoptic Feb 14, 2020
8db1cd9
changing testing_pytest back to testing
djarecka Feb 17, 2020
0117212
TEST: Remove last imports of nose
effigies Feb 18, 2020
c9d9eba
MNT: Purge nose from requirements, CI
effigies Feb 18, 2020
1c6ea64
RF: Remove nose test state code
effigies Feb 18, 2020
ff922aa
RF: Reimplement nibabel.test() and nibabel.bench()
effigies Feb 18, 2020
6dc8f0f
DOC: Replace nose with pytest in the docs
effigies Feb 18, 2020
0079255
DOC: Update benchmark docstrings
effigies Feb 18, 2020
154b941
TEST: Final few assert_raises
effigies Feb 18, 2020
f043012
CI: Add OSX test to Travis
effigies Feb 18, 2020
9e512bc
Merge remote-tracking branch 'upstream/master' into pytest
effigies Feb 18, 2020
3a38200
Merge pull request #891 from effigies/test/final_nose_purge
effigies Feb 19, 2020
c2a8b52
CI: Fix wheel build... weird pip behavior while in source directory
effigies Feb 19, 2020
b190eeb
Merge remote-tracking branch 'upstream/master' into pytest
effigies Feb 19, 2020
22d8c65
FIX: Return pytest.main results from nibabel.test/bench
effigies Feb 19, 2020
49be50a
TEST: Might as well test the testers. Found a bug.
effigies Feb 20, 2020
c049a4e
CI: Install test requirements through extra dependencies
effigies Feb 20, 2020
592b310
DOC: Specify current benchmark file
effigies Feb 20, 2020
7392e8f
TEST: Style and parameterization fixes for readability
effigies Feb 20, 2020
a7f8e11
TEST: Bad test syntax
effigies Feb 20, 2020
6061651
TEST/RF: Mock compress_ext_map, instead of fixture
effigies Feb 20, 2020
a98b023
TEST: Rename tests to ensure running
effigies Feb 20, 2020
5657d01
TEST/RF: Reparametrize tests
effigies Feb 20, 2020
aec0837
Typo fix
ZviBaratz Feb 20, 2020
23f3875
Merge pull request #893 from ZviBaratz/patch-1
effigies Feb 20, 2020
d9298ed
Merge pull request #865 from nipy/pytest
effigies Feb 24, 2020
0ecbf8d
CI: Fail test if docs do not build
effigies Mar 5, 2020
cc20e28
PY3: Drop Python 2 guards, use runpy instead of exec
effigies Mar 5, 2020
03c6c31
DOC: Attempt to find versioneer version when building docs
effigies Mar 5, 2020
92dc3f1
DOC: Skip py3k
effigies Mar 5, 2020
b57cf1b
DOC: Fix "``s" pattern in changelog
effigies Mar 5, 2020
4ac9821
DOC: Address warnings and improve formatting
effigies Mar 5, 2020
ee19d7a
Merge pull request #894 from effigies/doc/update_config
effigies Mar 6, 2020
d4598db
Typo fix
ZviBaratz Feb 20, 2020
05662b2
MNT: Update changelog, author list and Zenodo
effigies Mar 6, 2020
b2c4209
MNT: Drop pyproject.toml for now
effigies Mar 7, 2020
4220f11
DOC: Note pyproject.toml removal in changelog
effigies Mar 9, 2020
ff7c276
MNT: 3.0.3dev
effigies Mar 9, 2020
04ed870
Merge branch 'maint/3.0.x'
effigies Mar 9, 2020
7a62503
NEP29+1y: Drop Python 3.5
effigies Mar 9, 2020
65d5fc6
CI: Drop 3.5 tests, set min to 3.6, pre-release to 3.8
effigies Mar 9, 2020
cb8da69
ENH: Add parser for Siemens "ASCCONV" text format
moloney Mar 3, 2016
216780d
TST: Update to use pytest
moloney Mar 24, 2020
ae39189
Merge Matthew's work
moloney Mar 24, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions .azure-pipelines/windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@

parameters:
name: ''
vmImage: ''
matrix: []

jobs:
- job: ${{ parameters.name }}
pool:
vmImage: ${{ parameters.vmImage }}
variables:
EXTRA_WHEELS: "https://5cf40426d9f06eb7461d-6fe47d9331aba7cd62fc36c7196769e4.ssl.cf2.rackcdn.com"
DEPENDS: numpy scipy matplotlib h5py pydicom
CHECK_TYPE: test
strategy:
matrix:
${{ insert }}: ${{ parameters.matrix }}

steps:
- task: UsePythonVersion@0
inputs:
versionSpec: '$(PYTHON_VERSION)'
addToPath: true
architecture: '$(PYTHON_ARCH)'
- script: |
echo %PYTHONHASHSEED%
displayName: 'Display hash seed'
- script: |
python -m pip install --upgrade pip setuptools>=30.3.0 wheel
displayName: 'Update build tools'
- script: |
python -m pip install --find-links %EXTRA_WHEELS% %DEPENDS%
displayName: 'Install dependencies'
- script: |
python -m pip install .[$(CHECK_TYPE)]
SET NIBABEL_DATA_DIR=%CD%\\nibabel-data
displayName: 'Install nibabel'
- script: |
mkdir for_testing
cd for_testing
cp ../.coveragerc .
pytest --doctest-modules --cov nibabel -v --pyargs nibabel
displayName: 'Pytest tests'
condition: and(succeeded(), eq(variables['CHECK_TYPE'], 'test'))
- script: |
python -m pip install codecov
cd for_testing
codecov
displayName: 'Upload To Codecov'
env:
CODECOV_TOKEN: $(CODECOV_TOKEN)
1 change: 1 addition & 0 deletions .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ omit =
*/externals/*
*/benchmarks/*
*/tests/*
nibabel/_version.py
2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nibabel/COMMIT_INFO.txt export-subst
nibabel/_version.py export-subst
107 changes: 107 additions & 0 deletions .github/CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
# Community Guidelines

Nibabel is a [NIPY](https://nipy.org) project, and we strive to adhere to the
[NIPY Community Code](https://nipy.org/conduct.html), reproduced below.

The NIPY community is a community of practice devoted to the use of the Python programming language
in the analysis of neuroimaging data. The following code of conduct is a guideline for our behavior
as we participate in this community.

It is based on, and heavily inspired by a reading of the Python community code of conduct, the
Apache foundation code of conduct, the Debian code of conduct, and the Ten Principles of Burning
Man.

## The code of conduct for the NIPY community

The Neuroimaging in Python (NIPY) community is made up of members with a diverse set of skills,
personalities, background, and experiences. We welcome these differences because they are the
source of diverse ideas, solutions and decisions about our work. Decisions we make affect users,
colleagues, and through scientific results, the general public. We take these consequences
seriously when making decisions. When you are working with members of the community, we encourage
you to follow these guidelines, which help steer our interactions and help keep NIPY a positive,
successful, and growing community.

### A member of the NIPY community is:

#### Open

Members of the community are open to collaboration. Be it on the reuse of data, on the
implementation of methods, on finding technical solutions, establishing best practices, and
otherwise. We are accepting of all who wish to take part in our activities, fostering an
environment where anyone can participate and everyone can make a difference.

#### Be collaborative!

Our work will be used by other people, and in turn we will depend on the work of others. When we
make something for the benefit of others, we are willing to explain to others how it works, so that
they can build on the work to make it even better. We are willing to provide constructive criticism
on the work of others and accept criticism of our own work, as the experiences and skill sets of
other members contribute to the whole of our efforts.

#### Be inquisitive!

Nobody knows everything! Asking questions early avoids many problems later, so questions are
encouraged, though they may be directed to the appropriate forum. Those who are asked should be
responsive and helpful, within the context of our shared goal of improving neuroimaging practice.

#### Considerate

Members of the community are considerate of their peers. We are thoughtful when addressing the
efforts of others, keeping in mind that often-times the labor was completed simply for the good of
the community. We are attentive in our communications, whether in person or online, and we are
tactful when approaching differing views.

#### Be careful in the words that you choose:

We value courtesy, kindness and inclusiveness in all our interactions. Therefore, we take
responsibility for our own speech. In particular, we avoid:

* Personal insults.
* Violent threats or language directed against another person.
* Sexist, racist, or otherwise discriminatory jokes and language.
* Any form of sexual or violent material.
* Sharing private content, such as emails sent privately or non-publicly, or unlogged forums such
as IRC channel history.
* Excessive or unnecessary profanity.
* Repeated harassment of others. In general, if someone asks you to stop, then stop.
* Advocating for, or encouraging, any of the above behaviour.

#### Try to be concise in communication

Keep in mind that what you write once will be read by many others. Writing a short email means
people can understand the conversation as efficiently as possible. Even short emails should always
strive to be empathetic, welcoming, friendly and patient. When a long explanation is necessary,
consider adding a summary.

Try to bring new ideas to a conversation, so that each message adds something unique to the
conversation. Keep in mind that, when using email, the rest of the thread still contains the other
messages with arguments that have already been made.

Try to stay on topic, especially in discussions that are already fairly long and complex.

#### Respectful

Members of the community are respectful. We are respectful of others, their positions, their
skills, their commitments, and their efforts. We are respectful of the volunteer and professional
efforts that permeate the NIPY community. We are respectful of the processes set forth in the
community, and we work within them. When we disagree, we are courteous and kind in raising our
issues.

## Incident Reporting

We put great value on respectful, friendly and helpful communication.

If you feel that any of our Nibabel communications lack respect, or are unfriendly or unhelpful,
please try the following steps:

* If you feel able, please let the person who has sent the email or comment that you found it
disrespectful / unhelpful / unfriendly, and why;

* If you don't feel able to do that, or that didn't work, please contact Chris Markiewicz directly
by email (<[email protected]>), and he will do his best to resolve it.
If you don't feel comfortable contacting Chris, please email Matthew Brett
(<[email protected]>) instead.

## Attribution

The vast majority of the above was taken from the NIPY Code of Conduct.
16 changes: 16 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Contributing to NiBabel

Welcome to the NiBabel repository!
We're excited you're here and want to contribute.

Please see the [NiBabel Developer Guidelines][link_devguide] on our
on our [documentation website][link_docs].

These guidelines are designed to make it as easy as possible to get involved.
If you have any questions that aren't discussed in our documentation, or it's
difficult to find what you're looking for, please let us know by opening an
[issue][link_issues]!

[link_docs]: https://nipy.org/nibabel
[link_devguide]: https://nipy.org/nibabel/devel/devguide.html
[link_issues]: https://github.com/poldracklab/fmriprep/issues
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,5 @@ Thumbs.db
doc/source/reference
venv/
.buildbot.patch
.vscode
for_testing/
5 changes: 4 additions & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
url = git://github.com/matthew-brett/nitest-minc2.git
[submodule "nipy-ecattest"]
path = nibabel-data/nipy-ecattest
url = https://github.com/freec84/nipy-ecattest
url = https://github.com/effigies/nipy-ecattest
[submodule "nibabel-data/nitest-freesurfer"]
path = nibabel-data/nitest-freesurfer
url = https://bitbucket.org/nipy/nitest-freesurfer.git
Expand All @@ -16,3 +16,6 @@
[submodule "nibabel-data/nitest-cifti2"]
path = nibabel-data/nitest-cifti2
url = https://github.com/demianw/nibabel-nitest-cifti2.git
[submodule "nibabel-data/nitest-dicom"]
path = nibabel-data/nitest-dicom
url = https://github.com/effigies/nitest-dicom
12 changes: 10 additions & 2 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ B. Nolan Nichols <[email protected]> Nolan Nichols <[email protected]
Basile Pinsard <[email protected]> bpinsard <[email protected]>
Basile Pinsard <[email protected]> bpinsard <[email protected]>
Ben Cipollini <[email protected]> Ben Cipollini <[email protected]>
Benjamin C Darwin <[email protected]>
Bertrand Thirion <[email protected]> bthirion <[email protected]>
Cameron Riddell <[email protected]> <[email protected]>
Christian Haselgrove <[email protected]> Christian Haselgrove <[email protected]>
Christopher J. Markiewicz <[email protected]> Chris Johnson <[email protected]>
Christopher J. Markiewicz <[email protected]> Chris Markiewicz <[email protected]>
Expand All @@ -38,18 +40,24 @@ Jean-Baptiste Poline <[email protected]> jbpoline <[email protected]>
Jon Haitz Legarreta <[email protected]> Jon Haitz Legarreta Gorroño <[email protected]>
Kesshi Jordan <[email protected]> kesshijordan <[email protected]>
Kevin S. Hahn <[email protected]> Kevin S. Hahn <[email protected]>
Konstantinos Raktivan <[email protected]> constracti <[email protected]>
Krish Subramaniam <[email protected]> Krish Subramaniam <[email protected]>
Krzysztof J. Gorgolewski <[email protected]>
Krzysztof J. Gorgolewski <[email protected]> <[email protected]>
Marc-Alexandre Côté <[email protected]> Marc-Alexandre Cote <[email protected]>
Mathias Goncalves <[email protected]> mathiasg <[email protected]>
Matthew Cieslak <[email protected]> Matt Cieslak <[email protected]>
Michael Hanke <[email protected]> <mhanke-guest@82381867-18eb-0310-98a2-9474e637aba2>
Michael Hanke <[email protected]> <[email protected]>
Nguyen, Ly <[email protected]> lxn2 <[email protected]>
Michiel Cottaar <[email protected]> Michiel Cottaar <[email protected]>
Ly Nguyen <[email protected]> lxn2 <[email protected]>
Oliver P. Hinds <[email protected]> ohinds <[email protected]>
Oscar Esteban <[email protected]>
Paul McCarthy <[email protected]> Paul McCarthy <[email protected]>
Satrajit Ghosh <[email protected]> Satrajit Ghosh <[email protected]>
Serge Koudoro <[email protected]> skoudoro <[email protected]>
Stephan Gerhard <[email protected]> Stephan Gerhard <[email protected]>
Thomas Roos <[email protected]> Roosted7 <[email protected]>
Venky Reddy <[email protected]> R3DDY97 <[email protected]>
Venkateswara Reddy Reddam <[email protected]> R3DDY97 <[email protected]>
Yaroslav O. Halchenko <[email protected]> <yoh-guest@82381867-18eb-0310-98a2-9474e637aba2>
Yaroslav O. Halchenko <[email protected]> Yaroslav Halchenko <[email protected]>
12 changes: 12 additions & 0 deletions .pep8speaks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
scanner:
diff_only: True # Only show errors caused by the patch
linter: flake8

message: # Customize the comment made by the bot
opened: # Messages when a new PR is submitted
header: "Hello @{name}, thank you for submitting the Pull Request!"
footer: "To test for issues locally, `pip install flake8` and then run `flake8 nibabel`."
updated: # Messages when new commits are added to the PR
header: "Hello @{name}, Thank you for updating!"
footer: "To test for issues locally, `pip install flake8` and then run `flake8 nibabel`."
no_errors: "Cheers! There are no style issues detected in this Pull Request. :beers: "
Loading