-
Notifications
You must be signed in to change notification settings - Fork 14
ENH: Verify derivatives are compatible with anatomical reference #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 56.61% 56.74% +0.12%
==========================================
Files 70 70
Lines 6747 6788 +41
Branches 828 831 +3
==========================================
+ Hits 3820 3852 +32
- Misses 2718 2727 +9
Partials 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@xxnagit would you mind testing this patch to verify it fixes your issue? |
I have to run this pipeline on HPC, if there is any docker image available, I'm more than happy to try it out. Thank you so much! |
sure, you can use |
I tried a few more subjects this time as the first time when I reported the bug it was just for one subject. I realized my input are quite different for the orientations, and the outputs of Bibsnet are not uniform due to the consistency with the original input. While when these derivatives are plugged into the infantFS (which requires neurological orientation), it may end up with errors for some cases not the others. This docker image however, can't handle all those variances. In one case with the orientation as aligned with infantFS, I do see the new docker image can tolerate the slight difference between the affine matrix. I'll see if aligning my error cases to the requested orientation can resolve the rest. Thank you! |
I have tried some more subjects, by orienting them as required, the error would now be reported on the affine matrix not similar enough. This can be manually changed though, but if new version would retain the original affine matrix, that is quite appreciated! Thank you so much! |
@xxnagit can you clarify - are the bibsnet outputs a different orientation than the input data? |
Sorry to make it confused. The outputs of bibsnet are the same of original inputs. The problem is on my end, my inputs are not of the same orientation which I supposed they were at the beginning. |
25.1.0 (June 24, 2025) First release of the 25.1.x series. A few key changes include a new workflow for derivatives compatibility when an anatomical template is not present, and performing a two step registration (currently only for MNI152NLin6Asym) is now the default behavior. This can be disabled by adding `--no-multi-step-reg` to the command. - Enhancements * ENH: Verify derivatives are compatible with anatomical reference (#459) * ENH: Make `--multi-step-reg` a boolean action, enable by default (#470) * ENH: Convert pooch retrieval to interface, allow setting cache dir (#467) - Internals / Maintenance * MAINT: bump dependencies, test on python 3.13 (#468) * MAINT: deprecate `--clean-workdir` (#473)
Closes #458
This was partially addressed with masks in #443. This implementation generalizes across files (mask, aseg) and across surface reconstruction methods.