Skip to content

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Apr 28, 2025

Closes #458

This was partially addressed with masks in #443. This implementation generalizes across files (mask, aseg) and across surface reconstruction methods.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

❌ Patch coverage is 75.34247% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.74%. Comparing base (1e6afd4) to head (d216490).
⚠️ Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/workflows/anatomical/fit.py 5.26% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   56.61%   56.74%   +0.12%     
==========================================
  Files          70       70              
  Lines        6747     6788      +41     
  Branches      828      831       +3     
==========================================
+ Hits         3820     3852      +32     
- Misses       2718     2727       +9     
  Partials      209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgxd
Copy link
Collaborator Author

mgxd commented Apr 29, 2025

@xxnagit would you mind testing this patch to verify it fixes your issue?

https://github.com/nipreps/nibabies/wiki/Testing

@xxnagit
Copy link

xxnagit commented Apr 29, 2025

I have to run this pipeline on HPC, if there is any docker image available, I'm more than happy to try it out. Thank you so much!

@mgxd
Copy link
Collaborator Author

mgxd commented Apr 29, 2025

sure, you can use nipreps/nibabies:derivatives-no-preproc

@xxnagit
Copy link

xxnagit commented Apr 30, 2025

I tried a few more subjects this time as the first time when I reported the bug it was just for one subject. I realized my input are quite different for the orientations, and the outputs of Bibsnet are not uniform due to the consistency with the original input. While when these derivatives are plugged into the infantFS (which requires neurological orientation), it may end up with errors for some cases not the others. This docker image however, can't handle all those variances. In one case with the orientation as aligned with infantFS, I do see the new docker image can tolerate the slight difference between the affine matrix. I'll see if aligning my error cases to the requested orientation can resolve the rest. Thank you!

@xxnagit
Copy link

xxnagit commented May 19, 2025

I have tried some more subjects, by orienting them as required, the error would now be reported on the affine matrix not similar enough. This can be manually changed though, but if new version would retain the original affine matrix, that is quite appreciated! Thank you so much!

@mgxd
Copy link
Collaborator Author

mgxd commented May 20, 2025

@xxnagit can you clarify - are the bibsnet outputs a different orientation than the input data?

@xxnagit
Copy link

xxnagit commented May 20, 2025

Sorry to make it confused. The outputs of bibsnet are the same of original inputs. The problem is on my end, my inputs are not of the same orientation which I supposed they were at the beginning.

@mgxd mgxd force-pushed the fix/preproc-hdr branch from b4f5a58 to 01defc8 Compare June 9, 2025 15:28
@mgxd mgxd merged commit ec18eaf into nipreps:master Jun 9, 2025
16 checks passed
@mgxd mgxd deleted the fix/preproc-hdr branch June 9, 2025 20:30
mgxd added a commit that referenced this pull request Jun 24, 2025
25.1.0 (June 24, 2025)

First release of the 25.1.x series. A few key changes include a new workflow
for derivatives compatibility when an anatomical template is not present, and performing
a two step registration (currently only for MNI152NLin6Asym) is now the default behavior.
This can be disabled by adding `--no-multi-step-reg` to the command.

- Enhancements
  * ENH: Verify derivatives are compatible with anatomical reference (#459)
  * ENH: Make `--multi-step-reg` a boolean action, enable by default (#470)
  * ENH: Convert pooch retrieval to interface, allow setting cache dir (#467)

- Internals / Maintenance
  * MAINT: bump dependencies, test on python 3.13 (#468)
  * MAINT: deprecate `--clean-workdir` (#473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using --derivatives from Bibsnet precomputed segmentation and mask

2 participants