Skip to content

Use nghttp3_conn_read_stream2 solely #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2025
Merged

Use nghttp3_conn_read_stream2 solely #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fuzz/fuzz_http3serverreq.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ void run_fuzzer(const uint8_t *data, size_t size, size_t step) {
settings.enable_connect_protocol =
fuzzed_data_provider.ConsumeIntegral<uint8_t>();
settings.h3_datagram = fuzzed_data_provider.ConsumeIntegral<uint8_t>();
settings.initial_ts = 0;

auto mem = *nghttp3_mem_default();
mem.user_data = &fuzzed_data_provider;
Expand All @@ -355,6 +356,7 @@ void run_fuzzer(const uint8_t *data, size_t size, size_t step) {
nghttp3_conn *conn;
auto shutdown_started = false;
auto server = fuzzed_data_provider.ConsumeBool();
nghttp3_tstamp ts = 0;

if (server) {
auto rv = nghttp3_conn_server_new(&conn, &callbacks, &settings, &mem,
Expand Down Expand Up @@ -418,11 +420,13 @@ void run_fuzzer(const uint8_t *data, size_t size, size_t step) {
auto chunk = fuzzed_data_provider.ConsumeBytes<uint8_t>(chunk_size);
auto v = std::span{chunk};
auto fin = fuzzed_data_provider.ConsumeBool();
ts = fuzzed_data_provider.ConsumeIntegralInRange<nghttp3_tstamp>(
ts, std::numeric_limits<nghttp3_tstamp>::max() - 1);

for (; !v.empty();) {
auto len = std::min(v.size(), step);
auto nread = nghttp3_conn_read_stream(conn, stream_id, v.data(), len,
v.size() == len && fin);
auto nread = nghttp3_conn_read_stream2(conn, stream_id, v.data(), len,
v.size() == len && fin, ts);
if (nread < 0) {
goto fin;
}
Expand Down
Loading
Loading