Use nghttp3_conn_read_stream2 solely

[tatsuhiro-t]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @tatsuhiro-t, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the stream reading functionality within the nghttp3 library by exclusively adopting nghttp3_conn_read_stream2. This change integrates timestamp handling into the stream processing, with updates made across the fuzzer and unit tests to reflect the new function signature and ensure proper initialization of related settings.

Highlights

• Function Standardization: All instances of the nghttp3_conn_read_stream function have been replaced with nghttp3_conn_read_stream2 across the fuzzer and test suite, standardizing the stream reading mechanism.
• Timestamp Integration: The nghttp3_conn_read_stream2 function now accepts an additional timestamp argument (ts), which is consistently initialized to 0 in test cases and fuzzed in the fuzzer to ensure robust handling.
• Settings Initialization: The settings.initial_ts = 0; parameter has been added to various test setups and fuzzer configurations to ensure consistent timestamp initialization for connection settings.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a large but straightforward refactoring to replace all calls to the deprecated nghttp3_conn_read_stream function with nghttp3_conn_read_stream2. This change introduces a new timestamp parameter, which is handled correctly: the fuzzer uses a monotonically increasing timestamp, while the unit tests consistently use a constant value of 0, which is appropriate for their scope. The related settings.initial_ts is also initialized consistently across all test setups. The changes are clean, correct, and I found no issues.