Skip to content

set Content-Length "" for jwks uri and enable test #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

set Content-Length "" for jwks uri and enable test #3607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/configs/version2/nginx-plus.virtualserver.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ server {
location = /_jwks_uri_server {
internal;
proxy_method GET;
proxy_set_header Content-Length "";
{{ if .KeyCache }}
proxy_cache jwks_uri;
proxy_cache_valid 200 12h;
Expand Down Expand Up @@ -382,6 +383,7 @@ server {
location = {{ $l.Path }}_jwks_uri {
internal;
proxy_method GET;
proxy_set_header Content-Length "";
{{ if .KeyCache }}
proxy_cache {{ $l.Path }}_jwks_uri;
proxy_cache_valid 200 12h;
Expand Down
3 changes: 1 addition & 2 deletions tests/suite/test_jwt_policies_jwksuri.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ def get_token(request):
)
class TestJWTPoliciesVsJwksuri:
@pytest.mark.parametrize("jwt_virtual_server", [jwt_vs_spec_src, jwt_vs_route_src])
@pytest.mark.flaky(max_runs=3)
@pytest.mark.skip(reason="under review for causing pipeline delays")
def test_jwt_policy_jwksuri(
self,
request,
Expand Down Expand Up @@ -110,6 +108,7 @@ def test_jwt_policy_jwksuri(
resp2 = requests.get(
virtual_server_setup.backend_1_url,
headers={"host": virtual_server_setup.vs_host, "token": token},
timeout=5,
)

delete_policy(kube_apis.custom_objects, pol_name, test_namespace)
Expand Down