Skip to content

set Content-Length "" for jwks uri and enable test #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

set Content-Length "" for jwks uri and enable test #3607

merged 1 commit into from
Mar 1, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Mar 1, 2023 •
edited
Loading

Proposed changes

  • sets proxy_set_header Content-Length ""; under server and location context for jwks-uri,
  • enables jwks-uri test, which was earlier disabled due to pipeline delays.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from haywoodsh and shaun-nx March 1, 2023 11:58
@github-actions github-actions bot added bug An issue reporting a potential bug tests Pull requests that update tests labels Mar 1, 2023
@vepatel vepatel marked this pull request as ready for review March 1, 2023 12:40
@vepatel vepatel requested a review from a team as a code owner March 1, 2023 12:40
@vepatel vepatel merged commit e971c37 into main Mar 1, 2023
@vepatel vepatel deleted the fix/proxy-set-header-jwks branch March 1, 2023 16:39
jjngx pushed a commit that referenced this pull request Mar 14, 2023
@vepatel @jjngx
set Content-Length "" for jwks uri and enable test (#3607)
aec628f
@MaxMood96 MaxMood96 mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

+1 more reviewer

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @haywoodsh @shaun-nx