Skip to content

Conversation

lucacome
Copy link

@lucacome lucacome commented Feb 14, 2023

Adds new labels to be used across our repos, updates CONTRIBUTING.md and ISSUE_LIFECYCLE.md.

@lucacome lucacome requested a review from a team as a code owner February 14, 2023 02:43
@lucacome lucacome self-assigned this Feb 14, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels Feb 14, 2023
@lucacome lucacome force-pushed the chore/update-labels branch from 17cfd2b to d46f9b3 Compare February 14, 2023 02:58
@lucacome lucacome changed the title Update labels Update labels and issue docs Feb 14, 2023
@lucacome lucacome requested a review from a team February 14, 2023 03:00
@lucacome lucacome force-pushed the chore/update-labels branch from d46f9b3 to 62064aa Compare February 14, 2023 03:03
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #3553 (f0ae4eb) into main (cb20b65) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3553   +/-   ##
=======================================
  Coverage   51.99%   51.99%           
=======================================
  Files          60       60           
  Lines       16820    16820           
=======================================
  Hits         8746     8746           
  Misses       7777     7777           
  Partials      297      297           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome force-pushed the chore/update-labels branch from 62064aa to 0823a1d Compare February 14, 2023 03:04
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but as best I can tell, the Issue Lifecycle isn't currently linked from anywhere specific (Such as a section of the CONTRIBUTING file).

This means that although the file is navigable, it's not easily discoverable.

Copy link
Contributor

@tomasohaodha tomasohaodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some labels use hyphens, some use underscores, and some use spaces. It looks inconsistent IMHO - can we standardize?

@lucacome lucacome force-pushed the chore/update-labels branch from 38efa8a to f0ae4eb Compare February 14, 2023 19:09
@lucacome
Copy link
Author

@tomasohaodha I've removed the -, the ones with underscores are the ones created (and used) by dependabot

@lucacome lucacome force-pushed the chore/update-labels branch from f0ae4eb to ea19e6e Compare February 15, 2023 17:38
@lucacome lucacome enabled auto-merge (squash) February 15, 2023 17:39
@lucacome lucacome merged commit e963fc0 into main Feb 15, 2023
@lucacome lucacome deleted the chore/update-labels branch February 15, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants