Skip to content

fix: Add OnDelete to allowed strategy values #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: Add OnDelete to allowed strategy values #3519

merged 1 commit into from
Feb 7, 2023

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Closes #3512

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner February 3, 2023 11:11
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Feb 3, 2023
@ciarams87 ciarams87 force-pushed the fix-helm-strategy-values branch from e7f36c2 to 47b59b8 Compare February 7, 2023 14:27
@ciarams87 ciarams87 enabled auto-merge (squash) February 7, 2023 14:27
@ciarams87 ciarams87 merged commit b5d400a into main Feb 7, 2023
@ciarams87 ciarams87 deleted the fix-helm-strategy-values branch February 7, 2023 14:35
ciarams87 added a commit that referenced this pull request Feb 13, 2023
@ciarams87
fix: Add OnDelete to allowed strategy values (#3519)
15261ac 
Add OnDelete to allowed strategy values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

controller.strategy.type: controller.strategy.type must be one of the following: "Recreate", "RollingUpdate"
3 participants
@ciarams87 @vepatel @jjngx