Skip to content

Commit 47b59b8

Browse files
committed
Add OnDelete to allowed strategy values
1 parent 2efa8d4 commit 47b59b8

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

deployments/helm-chart/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ Parameter | Description | Default
256256
`controller.autoscaling.maxReplicas` | Maximum number of replicas for the HPA. | 3
257257
`controller.autoscaling.targetCPUUtilizationPercentage` | The target CPU utilization percentage. | 50
258258
`controller.autoscaling.targetMemoryUtilizationPercentage` | The target memory utilization percentage. | 50
259-
`controller.strategy` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {}
259+
`controller.strategy` | Specifies the strategy used to replace old Pods with new ones. Docs for [Deployment update strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) and [Daemonset update strategy](https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/#daemonset-update-strategy) | {}
260260
`controller.disableIPV6` | Disable IPV6 listeners explicitly for nodes that do not support the IPV6 stack. | false
261261
`rbac.create` | Configures RBAC. | true
262262
`prometheus.create` | Expose NGINX or NGINX Plus metrics in the Prometheus format. | true

deployments/helm-chart/values.schema.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,8 @@
516516
"type": "string",
517517
"enum": [
518518
"Recreate",
519-
"RollingUpdate"
519+
"RollingUpdate",
520+
"OnDelete"
520521
]
521522
}
522523
}

deployments/helm-chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ controller:
179179
## The minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available.
180180
minReadySeconds: 0
181181

182-
## Strategy used to replace old Pods by new ones. .spec.strategy.type can be "Recreate" or "RollingUpdate". "RollingUpdate" is the default value.
182+
## Strategy used to replace old Pods by new ones. .spec.strategy.type can be "Recreate" or "RollingUpdate" for Deployments, and "OnDelete" or "RollingUpdate" for Daemonsets. "RollingUpdate" is the default value.
183183
strategy: {}
184184

185185
## Extra containers for the Ingress Controller pods.

docs/content/installation/installation-with-helm.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont
244244
|``controller.autoscaling.maxReplicas`` | Maximum number of replicas for the HPA. | 3 |
245245
|``controller.autoscaling.targetCPUUtilizationPercentage`` | The target CPU utilization percentage. | 50 |
246246
|``controller.autoscaling.targetMemoryUtilizationPercentage`` | The target memory utilization percentage. | 50 |
247-
|``controller.strategy`` | Specifies the strategy used to replace old Pods with new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} |
247+
|``controller.strategy`` | Specifies the strategy used to replace old Pods with new ones. Docs for [Deployment update strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) and [Daemonset update strategy](https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/#daemonset-update-strategy). | {} |
248248
| `controller.disableIPV6` | Disable IPV6 listeners explicitly for nodes that do not support the IPV6 stack. | false |
249249
|``rbac.create`` | Configures RBAC. | true |
250250
|``prometheus.create`` | Expose NGINX or NGINX Plus metrics in the Prometheus format. | false |

0 commit comments

Comments
 (0)