-
Notifications
You must be signed in to change notification settings - Fork 8
First iteration of development deployments & environments #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First iteration of development deployments & environments #4
Conversation
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
86e4726
to
c679724
Compare
/retest |
/lgtm |
@shaneutt I'm not sure I got the point. |
@nirrozenbaum your comment is correct - we need to validate this on our GIE fork and not the inference-router images. I think you're seeing the references as @shaneutt was porting the code over from that repo. I'm going through this to
|
FYI. Once approved and merged it will be deployed in the cluster for all to use. |
There is a target in your makefile to deploy to kube or docker using podman or docker. |
/approve |
Yes you're right @nirrozenbaum, but that was intentional: this was just a first step I did late last night and needed to share so that @elevran could grab it and start the next iteration in his morning. So, as he mentions, next step is swapping in the GIE images and making any adaptations needed for that. After that we're going to take all these building blocks and tweak them for vanilla Kubernetes and OpenShift, and we intend to have them packaged up in a way people can use them on a shared OpenShift cluster (see #3 for the full goal). |
This is a first pass at adding deployment manifests and scripts for development environments, in service of #3.
This adds deployments for various components:
Gateways
)Gateway
+Endpoint Picker (EPP)
viaext_proc
) exposed viaHTTPRoute
This also adds an initial deployment for a kind-based development environment, and a script which will set it all up automatically.
I've tested this on Linux with
podman
: I was able to make changes to the EPP and test them and things are working.This is very much the first iteration, and there's a lot more to do. Next we'll need to adapt these pieces for dev envs on OpenShift. For now though it's functional at a basic level and provides several building blocks for later so should be a reasonable starting point.
Fixes #11