Skip to content

Conversation

@jonahsnider
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Users must always explicitly provide options.length when constructing a StreamableFile.

What is the new behavior?

When a Uint8Array is provided to the constructor of StreamableFile, options.length will be ??= to the Uint8Array's length.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 98560942-593e-45a6-bccb-de3ce381fc12

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 94.121%

Totals Coverage Status
Change from base Build 4207ecc6-d73b-40a7-9a5d-57e04fd83620: 0.001%
Covered Lines: 5763
Relevant Lines: 6123

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit be6848d into nestjs:master Apr 7, 2022
@jonahsnider jonahsnider deleted the feat/streamable-file-auto-length branch April 7, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants