Merge pull request #9435 from jonahsnider/feat/streamable-file-auto-length

kamilmysliwiec · web-flow · commit be6848dac9a7 · 2022-04-07T13:32:29.000+02:00
feat(common): set default StreamableFile length automatically when possible
diff --git a/packages/common/file-stream/streamable-file.ts b/packages/common/file-stream/streamable-file.ts
@@ -16,6 +16,7 @@ export class StreamableFile {
       this.stream = new Readable();
       this.stream.push(bufferOrReadStream);
       this.stream.push(null);
+      this.options.length ??= bufferOrReadStream.length;
     } else if (bufferOrReadStream.pipe && isFunction(bufferOrReadStream.pipe)) {
       this.stream = bufferOrReadStream;
     }

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ export class StreamableFile {`
`16`	`16`	`this.stream = new Readable();`
`17`	`17`	`this.stream.push(bufferOrReadStream);`
`18`	`18`	`this.stream.push(null);`
	`19`	`+ this.options.length ??= bufferOrReadStream.length;`
`19`	`20`	`} else if (bufferOrReadStream.pipe && isFunction(bufferOrReadStream.pipe)) {`
`20`	`21`	`this.stream = bufferOrReadStream;`
`21`	`22`	`}`