Skip to content

Fix links not being blue and not being highlighted in the sidebar #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Fix links not being blue and not being highlighted in the sidebar #1809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e1a2de
Change from <a> tags to DrawerExternalLink in About page
BjornMagn-Neo4j Aug 24, 2022
6fa913b
Add hover color to links in StyledSidebarSlide.
BjornMagn-Neo4j Aug 25, 2022
a7a5b34
Update test to accomodate new autogenerated class tag
BjornMagn-Neo4j Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/browser/modules/Carousel/styled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,9 @@ export const StyledSidebarSlide = styled.div.attrs({
text-decoration: ${props =>
props.theme.name === 'dark' ? 'underline' : 'none'};
}
& a:hover {
color: ${dark.linkHover};
}
& kbd {
color: ${dark.primaryBackground} !important; /* inverted */
background-color: ${dark.primaryText} !important;
Expand Down
87 changes: 27 additions & 60 deletions src/browser/modules/Sidebar/About.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { connect } from 'react-redux'
import {
Drawer,
DrawerBody,
DrawerExternalLink,
DrawerFooter,
DrawerHeader,
DrawerSection,
Expand Down Expand Up @@ -62,9 +63,9 @@ const About = ({ serverVersion, serverEdition }: AboutProps) => (
<DrawerSection>
<DrawerSubHeader>
Made by{' '}
<a target="_blank" rel="noreferrer" href="http://neo4j.com/">
<DrawerExternalLink href="http://neo4j.com/">
Neo4j, Inc
</a>
</DrawerExternalLink>
</DrawerSubHeader>
</DrawerSection>
<DrawerSection>
Expand All @@ -77,35 +78,25 @@ const About = ({ serverVersion, serverEdition }: AboutProps) => (
<DrawerSectionBody>
<p>
Neo4j Browser version:{' '}
<a
<DrawerExternalLink
href={`https://github.com/neo4j/neo4j-browser/releases/tag/${browserVersion}`}
target="_blank"
rel="noreferrer"
>
{browserVersion}
</a>
</DrawerExternalLink>
</p>
{serverVersion && serverEdition && (
<p>
Neo4j Server version:{' '}
<a
target="_blank"
rel="noreferrer"
href={asChangeLogUrl(serverVersion)}
>
<DrawerExternalLink href={asChangeLogUrl(serverVersion)}>
{serverVersion}
</a>{' '}
</DrawerExternalLink>{' '}
({serverEdition})
</p>
)}
<p>
<a
href="https://github.com/neo4j/neo4j-browser/wiki/changelog"
target="_blank"
rel="noreferrer"
>
<DrawerExternalLink href="https://github.com/neo4j/neo4j-browser/wiki/changelog">
Neo4j Browser Changelog
</a>
</DrawerExternalLink>
</p>
{__BUILD_NUMBER__ && (
<div onClick={() => copyToClipboard(__BUILD_NUMBER__)}>
Expand All @@ -127,75 +118,51 @@ const About = ({ serverVersion, serverEdition }: AboutProps) => (
<DrawerSection>
<DrawerSubHeader>License</DrawerSubHeader>
<DrawerSectionBody>
<a
target="_blank"
rel="noreferrer"
href="http://www.gnu.org/licenses/gpl.html"
>
<DrawerExternalLink href="http://www.gnu.org/licenses/gpl.html">
GPLv3
</a>{' '}
</DrawerExternalLink>{' '}
or{' '}
<a
target="_blank"
rel="noreferrer"
href="http://www.gnu.org/licenses/agpl-3.0.html"
>
<DrawerExternalLink href="http://www.gnu.org/licenses/agpl-3.0.html">
AGPL
</a>{' '}
</DrawerExternalLink>{' '}
for Open Source, and{' '}
<a
target="_blank"
rel="noreferrer"
href="https://neo4j.com/licensing/"
>
<DrawerExternalLink href="https://neo4j.com/licensing/">
NTCL
</a>{' '}
</DrawerExternalLink>{' '}
Commercial.
</DrawerSectionBody>
</DrawerSection>
<DrawerSection>
<DrawerSubHeader>Participate</DrawerSubHeader>
<DrawerSectionBody>
Discuss on{' '}
<a
target="_blank"
rel="noreferrer"
href="https://community.neo4j.com/"
>
<DrawerExternalLink href="https://community.neo4j.com/">
Neo4j Community Forum
</a>{' '}
</DrawerExternalLink>{' '}
<br />
Ask questions at{' '}
<a
target="_blank"
rel="noreferrer"
href="http://stackoverflow.com/questions/tagged/neo4j"
>
<DrawerExternalLink href="http://stackoverflow.com/questions/tagged/neo4j">
Stack Overflow
</a>
</DrawerExternalLink>
<br />
Visit a local{' '}
<a target="_blank" rel="noreferrer" href="http://neo4j.meetup.com/">
<DrawerExternalLink href="http://neo4j.meetup.com/">
Meetup Group
</a>
</DrawerExternalLink>
<br />
Contribute code to{' '}
<a target="_blank" rel="noreferrer" href="http://github.com/neo4j">
<DrawerExternalLink href="http://github.com/neo4j">
Neo4j
</a>{' '}
</DrawerExternalLink>{' '}
or{' '}
<a
target="_blank"
rel="noreferrer"
href="http://github.com/neo4j/neo4j-browser"
>
<DrawerExternalLink href="http://github.com/neo4j/neo4j-browser">
Neo4j Browser
</a>
</DrawerExternalLink>
<br />
Send us your Browser feedback via{' '}
<a href="mailto:[email protected]?subject=Neo4j Browser feedback">
<DrawerExternalLink href="mailto:[email protected]?subject=Neo4j Browser feedback">
email
</a>
</DrawerExternalLink>
</DrawerSectionBody>
</DrawerSection>
<DrawerSection>
Expand Down
4 changes: 2 additions & 2 deletions src/browser/modules/Sidebar/__snapshots__/GuideDrawer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
class="sc-khQegj jfEAI"
/>
<div
class="sc-fWCJzd jkzpjJ slide"
class="sc-fWCJzd fWxPIy slide"
style="padding: 0px 15px;"
>
You can also access Browser guides by running
Expand Down Expand Up @@ -241,7 +241,7 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
class="sc-khQegj jfEAI"
/>
<div
class="sc-fWCJzd jkzpjJ slide"
class="sc-fWCJzd fWxPIy slide"
style="padding: 0px 15px;"
>
You can also access Browser guides by running
Expand Down
1 change: 1 addition & 0 deletions src/browser/styles/themes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ export const dark = {
headerText: '#f4f4f4',
primaryHeaderText: '#f4f4f4',
link: '#5CA6D9',
linkHover: '#1e70bf',
topicText: '#fff',
preText: '#fff',
asideText: 'rgb(255, 255, 255, 0.87)',
Expand Down