Skip to content

Fix links not being blue and not being highlighted in the sidebar #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2022
Merged

Fix links not being blue and not being highlighted in the sidebar #1809

merged 3 commits into from
Aug 25, 2022

Conversation

@BjornMagn-Neo4j
Copy link
Contributor

@BjornMagn-Neo4j BjornMagn-Neo4j commented Aug 24, 2022 •
edited
Loading

This PR actually consists of 2 fixes connected to links in the sidebar

  • Fix links not being blue in the About page by replacing tags with DrawerExternalLinks. This is in line with how links are created on other sidebar pages.
  • Fix links not changing color when being hovered over in the sidebar guides by adding styling to the StyledSidebarSlide component and also a hover color in the dark theme (the hover color of the base theme was very similar to the non-hover color of the dark theme)

@BjornMagn-Neo4j
Copy link
Contributor Author

https://trello.com/c/EDCVP1rW/2034-hyperlinks-not-showing-as-blue-in-about-panel

@BjornMagn-Neo4j BjornMagn-Neo4j changed the title Change from <a> tags to DrawerExternalLink in About page Fix links not being blue and not being highlighted in the sidebar Aug 25, 2022
@noahmay noahmay merged commit ae155b8 into neo4j:master Aug 25, 2022
noahmay pushed a commit to BjornMagn-Neo4j/neo4j-browser that referenced this pull request Mar 8, 2023
@BjornMagn-Neo4j @noahmay
Fix links not being blue and not being highlighted in the sidebar (ne…
2f747ff 
…o4j#1809)

* Change from <a> tags to DrawerExternalLink in About page

* Add hover color to links in StyledSidebarSlide.

* Update test to accomodate new autogenerated class tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noahmay noahmay noahmay approved these changes

Assignees

No one assigned

Labels

changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BjornMagn-Neo4j @noahmay @OskarDamkjaer