Skip to content

Conversation

@chris1384
Copy link
Contributor

Make the "Enable rotation patches" work as a toggle between the current rotation behaviour and the old 1.5.9 rotation.
editor_gui field might need a renaming.
Also fixes #537

Make the "Enable rotation patches" work as a toggle between the current rotation behaviour and the old 1.5.9 rotation.
editor_gui field might need a renaming.
@dnl-k
Copy link
Contributor

dnl-k commented Aug 29, 2024

That's quite redundant if you ask me

@chris1384
Copy link
Contributor Author

That's quite redundant if you ask me

I don't think anyone uses the current LCTRL for X and Y transforms, players being used to the old mechanic can safely use the newer editor without experiencing these bind changes, instead of being stuck to the older, unstable ones.

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor nitpick. I have no issue with changing the default rotation behavior but others may disagree, so I'd rather wait for more feedback (a week or two max).

@dnl-k
Copy link
Contributor

dnl-k commented Sep 1, 2024

imo the default rotation behaviour should be the one before the "Rotation improvements"
It should've never been changed.

The "improved" one can be toggleable via said setting

@jlillis
Copy link
Contributor

jlillis commented Sep 7, 2024

Haven't had anyone disagree with the change in behavior so I think we'll merge this. If anyone complains in the future we may need to re-evaluate.

@jlillis jlillis merged commit 83e2c79 into multitheftauto:master Sep 7, 2024
@chris1384 chris1384 deleted the rotation-fix branch September 7, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor: Object getting flipped when rotating

3 participants