test(NODE-4962): sync range index spec tests #3528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Jan 18, 2023
| @@ -75,7 +75,7 @@ describe('Client Side Encryption (Legacy)', function () { | |||
| const testSuites = gatherTestSuites( | |||
| path.join(__dirname, '../../spec/client-side-encryption/tests/legacy'), | |||
| testContext | |||
| ); | |||
| ).filter(({ name }) => !name.includes('fle2-Range')); | |||
There was a problem hiding this comment.
Not our usual method for skipping tests because they do not appear in test output - but because I am about to implement the logic for these tests, it was easier than listing out all tests to skip into an array.
nbbeeken
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
LGTM
Just for posterity, this sync does not include the decimal128 range tests, follow up is tracked here: https://jira.mongodb.org/browse/NODE-4966
baileympearson
added a commit
to baileympearson/node-mongodb-native
that referenced
this pull request
Jan 23, 2023
baileympearson
added a commit
that referenced
this pull request
Jan 24, 2023
baileympearson
added a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
New spec tests for range index support are synced.
Is there new documentation needed for these changes?
No.