Skip to content

Missing release notes + goreleaser fix/todo #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025

Conversation

MaciejKaras
Copy link
Collaborator

@MaciejKaras MaciejKaras commented May 12, 2025

Summary

Missing release notes + goreleaser fix/todo

Proof of Work

No changes in the code. goreleaser was successfully tested during release

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@MaciejKaras MaciejKaras changed the base branch from master to release-1.0 May 12, 2025 20:15
@MaciejKaras MaciejKaras force-pushed the fix/mk-add-missing-rn branch from 516733c to 099f0af Compare May 13, 2025 07:35
@MaciejKaras MaciejKaras marked this pull request as ready for review May 13, 2025 07:35
@MaciejKaras MaciejKaras requested a review from a team as a code owner May 13, 2025 07:35
@MaciejKaras MaciejKaras enabled auto-merge (squash) May 13, 2025 08:17
@MaciejKaras
Copy link
Collaborator Author

evergreen retry

@MaciejKaras MaciejKaras force-pushed the fix/mk-add-missing-rn branch from 62bb502 to bdbff0e Compare May 13, 2025 09:32
@MaciejKaras MaciejKaras disabled auto-merge May 13, 2025 09:34
@MaciejKaras
Copy link
Collaborator Author

evergreen retry

1 similar comment
@MaciejKaras
Copy link
Collaborator Author

evergreen retry

@MaciejKaras MaciejKaras enabled auto-merge (squash) May 13, 2025 09:39
@MaciejKaras MaciejKaras disabled auto-merge May 13, 2025 11:43
@MaciejKaras MaciejKaras force-pushed the fix/mk-add-missing-rn branch from e0ab385 to effc7c5 Compare May 13, 2025 11:46
@MaciejKaras MaciejKaras force-pushed the fix/mk-add-missing-rn branch from effc7c5 to 2e5b1b4 Compare May 13, 2025 11:48
@MaciejKaras MaciejKaras merged commit 0b17e4d into release-1.0 May 14, 2025
36 checks passed
@MaciejKaras MaciejKaras deleted the fix/mk-add-missing-rn branch May 14, 2025 08:07
@MaciejKaras MaciejKaras mentioned this pull request May 14, 2025
3 tasks
MaciejKaras added a commit that referenced this pull request May 14, 2025
# Summary

Missing release notes + goreleaser fix/todo

## Proof of Work

No changes in the code. `goreleaser` was successfully tested during
release

## Checklist
- [ ] Have you linked a jira ticket and/or is the ticket in the title?
- [ ] Have you checked whether your jira ticket required DOCSP changes?
- [ ] Have you checked for release_note changes?

## Reminder (Please remove this when merging)
- Please try to Approve or Reject Changes the PR, keep PRs in review as
short as possible
- Our Short Guide for PRs:
[Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0)
- Remember the following Communication Standards - use comment prefixes
for clarity:
  * **blocking**: Must be addressed before approval.
  * **follow-up**: Can be addressed in a later PR or ticket.
  * **q**: Clarifying question.
  * **nit**: Non-blocking suggestions.
  * **note**: Side-note, non-actionable. Example: Praise
  * --> no prefix is considered a question

---------

Co-authored-by: Simon Bäumer <[email protected]>
MaciejKaras added a commit that referenced this pull request May 14, 2025
# Summary

Missing release notes + goreleaser fix/todo

## Proof of Work

No changes in the code. `goreleaser` was successfully tested during
release

## Checklist
- [ ] Have you linked a jira ticket and/or is the ticket in the title?
- [ ] Have you checked whether your jira ticket required DOCSP changes?
- [ ] Have you checked for release_note changes?

## Reminder (Please remove this when merging)
- Please try to Approve or Reject Changes the PR, keep PRs in review as
short as possible
- Our Short Guide for PRs:
[Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0)
- Remember the following Communication Standards - use comment prefixes
for clarity:
  * **blocking**: Must be addressed before approval.
  * **follow-up**: Can be addressed in a later PR or ticket.
  * **q**: Clarifying question.
  * **nit**: Non-blocking suggestions.
  * **note**: Side-note, non-actionable. Example: Praise
  * --> no prefix is considered a question

---------

Co-authored-by: Simon Bäumer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants