Add missing e2e_smoke_release context #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejKaras
force-pushed
the
fix/mk-smoke-tests
branch
from
76c5422 to
269db5c
Compare
mircea-cosbuc
approved these changes
May 12, 2025
MaciejKaras
changed the title
nammn
approved these changes
May 13, 2025
SimonBaeumer
approved these changes
May 13, 2025
Comment on lines
+28
to
+29
| DATABASE_VERSION="$(grep -o '"databaseImageVersion": "[^"]*' release.json | grep -o '[^"]*$')" | ||
| export DATABASE_VERSION |
There was a problem hiding this comment.
nit: is this not possible? 🤔
Suggested change
| DATABASE_VERSION="$(grep -o '"databaseImageVersion": "[^"]*' release.json | grep -o '[^"]*$')" | |
| export DATABASE_VERSION | |
| export DATABASE_VERSION="$(grep -o '"databaseImageVersion": "[^"]*' release.json | grep -o '[^"]*$')" |
There was a problem hiding this comment.
Probably it's possible, let's see ;) I just copied the existing e2e_smoke and e2e_static_smoke, didn't dive into what's exactly inside
|
evergreen refresh |
|
evergreen retry |
anandsyncs
approved these changes
May 13, 2025
|
evergreen refresh |
MaciejKaras
force-pushed
the
fix/mk-smoke-tests
branch
from
8e04f33 to
4ecea8a
Compare
|
evergreen retry |
This was referenced May 13, 2025
Merged
MaciejKaras
added a commit
that referenced
this pull request
May 14, 2025
# Summary Add missing `e2e_smoke_release` and `e2e_static_smoke_release` context. Previous error: ```(!!) Cannot switch context: File scripts/dev/contexts/e2e_static_smoke_release does not exist.``` ## Proof of Work https://spruce.mongodb.com/version/68224ca9feee0e0007c41c3c/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question --------- Co-authored-by: Nam Nguyen <[email protected]>
MaciejKaras
added a commit
that referenced
this pull request
May 14, 2025
# Summary Add missing `e2e_smoke_release` and `e2e_static_smoke_release` context. Previous error: ```(!!) Cannot switch context: File scripts/dev/contexts/e2e_static_smoke_release does not exist.``` ## Proof of Work https://spruce.mongodb.com/version/68224ca9feee0e0007c41c3c/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question --------- Co-authored-by: Nam Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
e2e_smoke_releaseande2e_static_smoke_releasecontext.Previous error:
(!!) Cannot switch context: File scripts/dev/contexts/e2e_static_smoke_release does not exist.Proof of Work
https://spruce.mongodb.com/version/68224ca9feee0e0007c41c3c/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Checklist
Reminder (Please remove this when merging)