Relax assertion when checking exception message #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
May 27, 2025
Merged
alcaeus
added a commit
that referenced
this pull request
Jun 4, 2025
* v2.1: (50 commits) Fix missing placeholder replacement in release output (#1717) Use more lax assertion when checking exception message (#1712) Test against stable 2.1 version of the extension (#1698) Use assume_role command before accessing secrets for atlas-data-lake tests PHPLIB-1656: Stop testing with MongoDB 4.0 (#1693) Make serverless tasks patch-only (#1692) Bump tests/specifications from `cea6c7d` to `9d0d3f0` (#1690) Bump tests/drivers-evergreen-tools from `21b4109` to `32fd8eb` (#1691) PHPLIB-847, PHPLIB-1627: BulkWriteCommand API (#1630) Bump tests/specifications from `0c41c8b` to `cea6c7d` (#1688) Bump tests/drivers-evergreen-tools from `fa58b39` to `21b4109` (#1689) Test next next minor PHP version with PHP 8.4 (#1685) Bump tests/drivers-evergreen-tools from `9be5587` to `fa58b39` (#1679) Bump tests/specifications from `43d2c7b` to `0c41c8b` (#1680) Bump tests/drivers-evergreen-tools from `cec0139` to `9be5587` (#1676) Bump tests/drivers-evergreen-tools from `d1e19b1` to `cec0139` (#1675) Bump tests/specifications from `6118deb` to `43d2c7b` (#1674) Bump tests/drivers-evergreen-tools from `f53da28` to `d1e19b1` (#1673) Test against stable 2.0 version of the extension (#1663) Bump tests/specifications from `f354960` to `6118deb` ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a test assertion for compatibility with the upcoming minor version of the extension. The newer libmongocrypt version bundled in that version adds the view name to the exception message, so the test would fail. This PR intentionally targets v2.1 as that version is tested with the upcoming minor version of the extension and would cause issues if we have to release a bugfix after merging mongodb/mongo-php-driver#1829.